873219 - Add callback for stop() in all Webfaker servers

Status: RESOLVED FIXED

(Webmaker Graveyard :: General, defect)

Description

[David Humphrey (:humph)]

This will touch login, MakeAPI, Webfaker, etc.  The goal is:

Webfaker.stop( function(){/* done! */} );

Comment 1

[David Humphrey (:humph)]

Multi-commit/multi-repo change:

* Login API: https://github.com/mozilla/node-webmaker-loginapi/pull/8 (will need npm re-publish)
* MakeAPI: https://github.com/mozilla/MakeAPI/pull/55 (will need npm re-publish)
* Webfaker: https://github.com/humphd/webfaker/pull/1 (will need npm re-publish)

Comment 2

[Matthew Schranz [:mjschranz]]

Looks good and sane to me. R+

Comment 3

[Chris DeCairos (:cade)]

R+

Comment 4

[David Humphrey (:humph)]

Landed:

* Login API: https://github.com/mozilla/node-webmaker-loginapi/commit/00268727cc45407fdcfa57ab11e894fe25ea4aa6 (now at version 0.1.1, needs npm publish)
* MakeAPI: https://github.com/mozilla/MakeAPI/commit/f7440244d194265cbda079bc32d94c6f41278156 (depends on loginapi re-publish to npm, needs npm publish)
* https://github.com/humphd/webfaker/commit/704ada47e2ab43fe319eba92f1e717dbfe5068fb (needs npm publish).

Sedge, I need you to re-`npm-publish` the node-webmaker-loginapi master branch for the mozilla repo--I update it (see above).  Also, I need you to talk to Jon/Ross about getting that shared so it's not blocked on you when we need to do it.

Once that's done, I can re-publish MakeAPI and Webfaker, and close this.

Comment 5

[David Humphrey (:humph)]

Assigning to Sedge to get the login stuff updated in npm to version 0.1.1

Comment 6

[David Humphrey (:humph)]

NOTE: error in travis for MakeAPI and friends is due to npm not finding the right versions, it will be fixed when we publish the above.

Comment 7

[David Humphrey (:humph)]

* webmaker-loginapi@0.1.1
* makeapi@0.1.3
* webfaker@0.0.2