fix hardcoded location in consumer.js for webmaker-loginapi

RESOLVED INVALID

Status

Webmaker
Login
RESOLVED INVALID
5 years ago
5 years ago

People

(Reporter: pomax, Unassigned)

Tracking

Details

(Reporter)

Description

5 years ago
right now the webmaker-loginapi location is hardcoded to "http://testapp:testpass@localhost:3000", let's change that to something based on env instead.
:pomax should this be added to the env.sample first? or using something that already exist in there?

Comment 2

5 years ago
Jons-MacBook-Pro:login.webmaker.org jon$ git grep http://testapp:testpass@localhost:3000
app/dev/consumer.js:    loginAPI = require( "webmaker-loginapi" )( "http://testapp:testpass@localhost:3000" );

If the consumer app is the only thing that needs changing, this isn't a high priority to fix
Closing this bug since we do not have /dev/ anymore
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → INVALID
You need to log in before you can comment on or make changes to this bug.