873228 - desktop fireplace is not handling unverified emails correctly

Status: VERIFIED FIXED

(Marketplace Graveyard :: Consumer Pages, defect, P1)

Description

[Kumar McMillan [:kumar]]

The login code for fireplace needs to say 

nav.id.request({
  experimental_allowUnverified: false
  ...
})

but only when on desktop.

Looking at the Zamboni code this was always broken but no one noticed. It surfaced in bug 873201 since that's the first time unverified handling is merged into a server that desktop would use.

Comment 1

[Kumar McMillan [:kumar]]

Fix is part of this pull which is held up by bug 873201 https://github.com/mozilla/fireplace/pull/123

Comment 2

[Christopher Van Wiemeersch [:cvan]]

Kumar, is this necessary?

Comment 3

[Kumar McMillan [:kumar]]

it's only necessary when either 1) someone decides to land bug 873201 or 2) the Persona team merges the unverified feature into login.persona.org. I don't think the latter is happening for another month but I'm not sure.

Comment 5

[Kumar McMillan [:kumar]]

surprise! #2 happened today

Fix: https://github.com/mozilla/fireplace/commit/415e3f1fc18bc7ce2487cac43e521503f3e107c5

hotfixing prod right now.

Comment 6

[Victor Carciu]

Please add some STRs , or mark the bug as [qa-] if no QA is needed.

Comment 7

[Kumar McMillan [:kumar]]

STR:
- open Marketplace dev/stage/prod on desktop
- click Sign-in from the gears icon

Expected: you are logged in successfully
Actual: you saw 'oops, login failure'

Comment 8

[Victor Carciu]

Verified as fixed following steps from comment #7