873243 - Default favicon shows up in awesomescreen before real favicons load

Status: RESOLVED WORKSFORME

(Firefox for Android Graveyard :: Awesomescreen, defect)

Description

[:Margaret Leibovic]

We should see if we can avoid showing any image until we have the real favicon, instead of showing the default favicon then swapping in the real favicon.

Comment 1

[Ian Barlow (:ibarlow)]

Agree 100%

Comment 2

[Chris Kitching [:ckitching]]

This would be an extremely simple tweak to the work I'm currently doing to the Favicon system. What's the current feeling about this? Do we still want this, or has the new about:home made you change your minds?
How exactly should "No image" be implemented? A blank space of the same size that the image would be, or nothing there at all, with the text reflowing into the space? (It typically doesn't take very long before the real icon pops into existence)
Also, sometimes, but rarely, sites have no Favicon at all - should such sites show the default Favicon, or still just blank? 
Personally I'm a fan of the default Favicon. What's the plan?

Comment 3

[:Margaret Leibovic]

(In reply to Chris Kitching [:ckitching] from comment #2)

> Also, sometimes, but rarely, sites have no Favicon at all - should such
> sites show the default Favicon, or still just blank? 
> Personally I'm a fan of the default Favicon. What's the plan?

Yes, we still want the default favicon if the site doesn't have an icon. This bug was filed about the fact that when we *do* have an for a site, sometimes we show the default favicon before replacing it with the real favicon.

We should verify that this is still an issue with the new about:home. I haven't really noticed this recently, but it may still exist.

Comment 4

[Ian Barlow (:ibarlow)]

(In reply to Chris Kitching [:ckitching] from comment #2)
> This would be an extremely simple tweak to the work I'm currently doing to
> the Favicon system. What's the current feeling about this? Do we still want
> this, or has the new about:home made you change your minds?
> How exactly should "No image" be implemented? A blank space of the same size
> that the image would be, or nothing there at all, with the text reflowing
> into the space? (It typically doesn't take very long before the real icon
> pops into existence)

I would suggest simply a blank space of the same size of the image. So we don't reflow text or anything, we just wait a moment for the favicon to appear.

> Also, sometimes, but rarely, sites have no Favicon at all - should such
> sites show the default Favicon, or still just blank? 

In that case, I would suggest showing the default favicon.

Comment 5

[Chris Kitching [:ckitching]]

(In reply to :Margaret Leibovic from comment #3)
> Yes, we still want the default favicon if the site doesn't have an icon.
> This bug was filed about the fact that when we *do* have an for a site,
> sometimes we show the default favicon before replacing it with the real
> favicon.
> 
> We should verify that this is still an issue with the new about:home. I
> haven't really noticed this recently, but it may still exist.

This happens in the history/bookmarks/other things that use TwoLinePageRow pages. If you go to a page, then go back to about:home, you get to see the default Favicon be replaced (When the page finishes downloading) with the real Favicon.

Comment 6

[Richard Newman [:rnewman]]

Dupe of Bug 923218 ?

Comment 7

[:Margaret Leibovic]

(In reply to Richard Newman [:rnewman] from comment #6)
> Dupe of Bug 923218 ?

Isn't bug 923218 just about the browser toolbar? This bug was filed about the awesomescreen lists, although it looks like this issue was resolved by the work lucasr did in bug 905685, and should maintain resolved with the new favicon cache work that landed. So I'll mark this WORKSFORME.