873255 - remove option to always show tabs

Status: RESOLVED FIXED

(Firefox for Metro Graveyard :: General, defect)

Description

[Allison Naaktgeboren :ally]

being removed from v1

Comment 1

[Allison Naaktgeboren :ally]

- remove option
- remove code that reads the pref & sets attribute
- remove css that needs that attribute
- remove curvy tab images that is now unused

This part will probably land in 2 parts

Comment 2

[Allison Naaktgeboren :ally]

Attachment: part 1: remove option

I do not have my ssh key with me, so I'll be checkin-needed once I have r+

Comment 3

[Matt Brubeck (:mbrubeck)]

Adding [leave open] so we remember to also remove the unused code.

Comment 4

[Frank Yan (:fryn)]

We also need to remove:

browser/metro/profile/metro.js lines 57-59

and all the relevant code in browser-ui.js.

Comment 5

[Allison Naaktgeboren :ally]

Attachment: part2: remove the rest of teh code

Comment 6

[Frank Yan (:fryn)]

We also need to remove tab-selection-(left|right).jpg and closetab-tabselected.png. I'll do that when pushing.

Comment 7

[Matt Brubeck (:mbrubeck)]

Comment on attachment 750805 [details] [diff] [review]
part2: remove the rest of teh code

Review of attachment 750805 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/metro/base/content/ContentAreaObserver.js
@@ +294,1 @@
>      return windowHeight - contextUIHeight;

This can just be "return windowHeight;"

(and eventually we can get rid of the separate "content height" but that's not necessary right now.)

Comment 8

[Frank Yan (:fryn)]

Pushed with mbrubeck's comment addressed and unused files and defines removed:
https://hg.mozilla.org/integration/mozilla-inbound/rev/c2e9ea39d104

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/c2e9ea39d104