Publish Thimble using <title> in URL

RESOLVED FIXED

Status

RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: jon, Assigned: jon)

Tracking

Details

(Whiteboard: s=2013w20)

Attachments

(1 attachment)

Comment hidden (empty)

Comment 2

5 years ago
added some comments to the pull request, still need to actually run it locally though.
(Assignee)

Comment 3

5 years ago
Fixed those nits up, and some other things

Comment 4

5 years ago
Comment on attachment 751098 [details] [review]
https://github.com/mozilla/thimble.webmaker.org/pull/66

runs fine, I don't see anything wrong codewise. r- because of the comments in the pull request for the moment though.
Attachment #751098 - Flags: review?(pomax) → review-

Comment 5

5 years ago
Comment on attachment 751098 [details] [review]
https://github.com/mozilla/thimble.webmaker.org/pull/66

you fixed everything! land this sucker.
Attachment #751098 - Flags: review- → review+

Updated

5 years ago
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Attachment mime type: text/plain → text/x-github-pull-request
You need to log in before you can comment on or make changes to this bug.