Closed
Bug 873264
Opened 11 years ago
Closed 11 years ago
Publish Thimble using <title> in URL
Categories
(Webmaker Graveyard :: Thimble, defect)
Webmaker Graveyard
Thimble
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: jon, Assigned: jon)
References
Details
(Whiteboard: s=2013w20)
Attachments
(1 file)
No description provided.
|
Assignee | |
Comment 1•11 years ago
|
||
Attachment #751098 -
Flags: review?(pomax)
added some comments to the pull request, still need to actually run it locally though.
|
|
Assignee | |
Comment 3•11 years ago
|
||
Fixed those nits up, and some other things
Comment on attachment 751098 [details] [review] https://github.com/mozilla/thimble.webmaker.org/pull/66 runs fine, I don't see anything wrong codewise. r- because of the comments in the pull request for the moment though.
Attachment #751098 -
Flags: review?(pomax) → review-
Comment on attachment 751098 [details] [review] https://github.com/mozilla/thimble.webmaker.org/pull/66 you fixed everything! land this sucker.
Attachment #751098 -
Flags: review- → review+
|
||
Comment 6•11 years ago
|
||
Commit pushed to master at https://github.com/mozilla/thimble.webmaker.org https://github.com/mozilla/thimble.webmaker.org/commit/f49899cf780bbf0ed67d909331784e2c8109befa Fix bug 873264 - Publish pages using <title> in URL
|
|
||
Updated•11 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
|
||
Updated•11 years ago
|
Attachment mime type: text/plain → text/x-github-pull-request
You need to log in
before you can comment on or make changes to this bug.
Description
•