Closed Bug 873320 Opened 7 years ago Closed 7 years ago

Pass in DEBUG defines into embedjs.py for self-hosted code.

Categories

(Core :: JavaScript Engine, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla24

People

(Reporter: shu, Assigned: shu)

Details

Attachments

(1 file)

The python script to concat and preprocess all the self-hosted JS code currently isn't passed DEBUG defines since those defines aren't part of $(DEFINES) or $(ACDEFINES).
Attached patch patchSplinter Review
Assignee: general → shu
Attachment #750828 - Flags: review?(gps)
Comment on attachment 750828 [details] [diff] [review]
patch

Review of attachment 750828 [details] [diff] [review]:
-----------------------------------------------------------------

I have no clue what embedjs.py does or why this is necessary.

The Makefile.in bits look good. I defer my build module review power to someone who is familiar with this.
Attachment #750828 - Flags: review?(gps)
Attachment #750828 - Flags: review?(tschneidereit)
Attachment #750828 - Flags: review?(tschneidereit) → review+
https://hg.mozilla.org/mozilla-central/rev/01ab963b3f31
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla24
You need to log in before you can comment on or make changes to this bug.