Closed
Bug 873325
Opened 11 years ago
Closed 11 years ago
Make topobjdir absolute
Categories
(Firefox Build System :: General, defect)
Firefox Build System
General
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla24
People
(Reporter: gps, Assigned: gps)
References
Details
Attachments
(1 file)
|
2.14 KB,
patch
|
glandium
:
review+
|
Details | Diff | Splinter Review |
It's been discussed before that we should normalize topobjdir to an absolute path in config.status. Let's just do it.
|
Assignee | |
Comment 1•11 years ago
|
||
Attachment #750834 -
Flags: review?(mh+mozilla)
|
|
Assignee | |
Updated•11 years ago
|
Assignee: nobody → gps
|
||
Comment 2•11 years ago
|
||
Comment on attachment 750834 [details] [diff] [review] Normalize topobjdir to an absolute path Review of attachment 750834 [details] [diff] [review]: ----------------------------------------------------------------- ::: build/autoconf/config.status.m4 @@ +87,5 @@ > if not os.path.isabs(topsrcdir): > rel = os.path.join(os.path.dirname(<<<__file__>>>), topsrcdir) > topsrcdir = os.path.normpath(os.path.abspath(rel)) > > +topobjdir = os.path.normpath(os.path.abspath(os.path.dirname(<<<__file__>>>))) abspath does normpath.
Attachment #750834 -
Flags: review?(mh+mozilla) → review+
|
|
Assignee | |
Comment 3•11 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/77d1e65e48e2 With redundant normpath removed.
Status: NEW → ASSIGNED
Target Milestone: --- → mozilla24
|
||
Comment 4•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/77d1e65e48e2
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
|
||
Updated•6 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•