873352 - [Bluetooth] Stop discovering before pairing or connecting

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Settings, defect)

Description

[Eric Chou [:ericchou] [:echou]]

Discovering devices is a heavy operation in Bluetooth. If we try to establish an outbound connection with discovering, it would not only extends the time to complete connection procedure, it may be even easier to cause connection failed.

If you take a look at Android's API document, in function BluetoothAdapter::CancelDiscovery(), it also mentions that "Because discovery is a heavyweight procedure for the Bluetooth adapter, this method should always be called before attempting to connect to a remote device with connect()."*

* http://developer.android.com/reference/android/bluetooth/BluetoothAdapter.html#cancelDiscovery%28%29

Comment 1

[Eric Chou [:ericchou] [:echou]]

Attachment: Link to https://github.com/mozilla-b2g/gaia/pull/9835

Comment 2

[Evelyn Hung]

Comment on attachment 750881 [details]
Link to https://github.com/mozilla-b2g/gaia/pull/9835

r=me, in this patch, we just reorder the API call sequence: always call stop discovery first.

Comment 3

[Evelyn Hung]

merged into gaia-master
https://github.com/mozilla-b2g/gaia/commit/5f266b4d7985ba51532acc9049a4dda0565b37a5

Comment 4

[Eric Chou [:ericchou] [:echou]]

Nominate this as leo+ since this small change could largely increase the successful rate of connecting. For bugs like bug 872976 and bug 871962, it would help. Please see bug 872976 comment 11 for more information.

Comment 5

[Evelyn Hung]

:jhford, this patch has been merged to gaia master in comment 3, please help uplift to v1-train, Thanks!

Comment 6

[John Ford [:jhford] CET/CEST Berlin Time]

Uplifted 5f266b4d7985ba51532acc9049a4dda0565b37a5 to:
v1-train: 9a315b24d15a3d06e86c6eeb0789733b4b101a6e