873409 - [Settings] Internet Sharing: Wi-Fi hotspot name overlaps the "Name" text when too large

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Settings, defect)

Description

[bov]

Steps:
 
2. Go to "Settings".
3. Select "Internet Sharing" under Network & Connectivity.
4. Select "Hotspot Settings" and add a large password over 20 characters.
5. Click "OK" in the top right to save the data.

Actual Results:
The text begins to overlap.

Expected Results:
After a specific number of character the text will be cut off and will display ellipsis.

Comment 1

[bov]

Attachment: Actual result typing a SSID network name over 20 chars

Comment 2

[bov]

PLEASE DON'T TAKE INTO ACCOUNT THE FIRST DESCRIPTION. THIS IS THE RIGHT ONE:

Tested on a Inari device. V 1.0.1 Build identifier: 20130516003416
Platform version: 18.0
Steps:
 
1. Go to "Settings".
2. Select "Internet Sharing" under Network & Connectivity.
3. Select "Hotspot Settings" and type a large SSID network name over 20 characters.
4. Click "OK" in the top right to save the data.

Actual Results:
The text typed overlaps the NAME field

Expected Results:
After a specific number of characters (20) the text will be cut off without overlaps any field.

Comment 3

[Mihai Cirlanaru [:mihai][:mcirlanaru]]

Rob, what do you think a good approach would be to tackle the overlapping text here?

One solution that I have in mind is to add the marquee I introduced with the patch for bug 871454.

Comment 4

[Rob MacDonald [:robmac]]

As much as I love the marquee, in this case I think it's best to truncate. Why? First, because the user is picking the name and, second, because they can always view the full name in the hotspot settings if required. So it's unlikely we'll create any usability issues.

When we've used the marquee it's typically been where the user doesn't have any other option and if there's a potential for a usability issue without the full string. In this case I don't think that applies.

Comment 5

[Mihai Cirlanaru [:mihai][:mcirlanaru]]

Thanks for your input on this, Rob. I will add the logic to truncate with ellipsis the overflowing WiFi HotSpot names.

Comment 6

[Mihai Cirlanaru [:mihai][:mcirlanaru]]

Attachment: Pull Request #10370 - Truncate overlapping SSID/password

Simple CSS fix that truncates (with ellipsis) long strings to avoid overlapping the label text. The solution allows the user to see the full string by tapping and swiping left/right.

The patch also fixed the (overlapping) password field which shows the same behavior as the hotspot name (SSID) field.

Comment 7

[Arthur Chen [:arthurcc][inactive after 6/30]]

Comment on attachment 762080 [details]
Pull Request #10370 - Truncate overlapping SSID/password

Mihai, I am not sure if the solution is okay. Let's get some UX inputs here.

Comment 8

[Arthur Chen [:arthurcc][inactive after 6/30]]

Please provide some inputs for handling lengthy SSID and password. Thanks!

Comment 9

[Wayne Chang [:wchang]]

Triage - not blocking. UX please suggest a solution for this even though not blocking leo release.

Comment 10

[Arthur Chen [:arthurcc][inactive after 6/30]]

With attachment 762080 [details] applied, the lengthy text is truncated as suggested in comment4. Meanwhile, users are able to scroll the text to view the full content.

Comment 12

[Stephany Wilkes]

Assigning needinfo to Casey even though this is not blocking. Blockers still take priority.

Comment 13

[Casey Yee]

A solution has already been provided in Comment 4.   The same behavior should also apply to the password field.

Comment 14

[Mihai Cirlanaru [:mihai][:mcirlanaru]]

Comment on attachment 762080 [details]
Pull Request #10370 - Truncate overlapping SSID/password

Updated the patch to just truncate the SSID and password fields ass comment 4 suggested.

Note: the issue highlighted by bug 890496 (i.e. the button to access the HotSpot Settings is not working) makes it impossible to test this patch for now (I tested it with the fix for bug 890496 applied).

Comment 15

[Arthur Chen [:arthurcc][inactive after 6/30]]

Comment on attachment 762080 [details]
Pull Request #10370 - Truncate overlapping SSID/password

Thanks for the effort, Mihai! r=me.

Comment 16

[Arthur Chen [:arthurcc][inactive after 6/30]]

master: https://github.com/mozilla-b2g/gaia/commit/db911cbbb69be04f999728b5b96204d0bf580ed6

Comment 17

[Mihai Cirlanaru [:mihai][:mcirlanaru]]

Thanks for landing the patch, Arthur!