873412 - [AccessFu] Implement performAction for clicking

Status: RESOLVED FIXED

(Core :: Disability Access APIs, defect)

Description

[Max Li [:maxli]]

Followup to bug 785144,

This doesn't work right now, e.g. you can't tap the braille overlay item to activate an item.

Comment 1

[Max Li [:maxli]]

Attachment: Patch

Comment 2

[Marco Zehe (:MarcoZ)]

Comment on attachment 752118 [details] [diff] [review]
Patch

>+    Services.obs.addObserver(this, 'Accessibility:ActivateObject', false);

Should this observer also be removed upon shutdown?

Comment 3

[Eitan Isaacson [:eeejay]]

Comment on attachment 752118 [details] [diff] [review]
Patch

Review of attachment 752118 [details] [diff] [review]:
-----------------------------------------------------------------

Yep. Looks good. Along with what Marco said.

Comment 4

[Kartikaya Gupta (email:[e-mail])]

Comment on attachment 752118 [details] [diff] [review]
Patch

Review of attachment 752118 [details] [diff] [review]:
-----------------------------------------------------------------

::: mobile/android/base/GeckoAccessibility.java
@@ +305,5 @@
>                                  default:
>                                      break;
>                                  }
>                              }
> +                            else if (action == AccessibilityNodeInfo.ACTION_CLICK && virtualViewId == VIRTUAL_CURSOR_POSITION) {

style nit: Please move this up onto the same line as the preceding }

Comment 5

[Max Li [:maxli]]

Attachment: Patch v2

Patch with comments addressed

Comment 6

[Eitan Isaacson [:eeejay]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/2f7b770b61bd

Comment 7

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/2f7b770b61bd