873415 - [AccessFu] Populate adjacent nodes with data

Status: RESOLVED WONTFIX

(Core :: Disability Access APIs, defect)

Description

[Max Li [:maxli]]

Followup to bug 785144,

BrailleBack makes use of the information from adjacent nodes too.

Comment 1

[Max Li [:maxli]]

Attachment: Patch

So here's a first attempt, though I'm not totally enthused by the behaviour. So what is kind of awkward is that the behaviour doesn't really match the native widgets, i.e. when you move to a node that's already exposed to BrailleBack, this patch changes what is being exposed (e.g. swiping forward should either only cause a change of the cursor focus or a complete change of text on the braille display), whereas on the native UI it would only change the accessibility focus. Also there's the fact that only three nodes are exposed at any given time.

Though I don't think it'd be particularly nice or easy to actually achieve the native behaviour.

Marco, could you take a look and see if this patch provides better behaviour than without (and/or suggest how it could be improved)?

Comment 2

[Max Li [:maxli]]

Attachment: Patch v2

Oops, the previous patch was slightly outdated (though everything I said still stood).

Comment 3

[Marco Zehe (:MarcoZ)]

Comment on attachment 752214 [details] [diff] [review]
Patch v2

This patch needs updating, it does not apply cleanly, hunk 2 fails in accessible/src/jsat/eventManager.jsm.

Comment 4

[Max Li [:maxli]]

Attachment: Patch v2.1

Updated patch

Comment 5

[Marco Zehe (:MarcoZ)]

Comment on attachment 752751 [details] [diff] [review]
Patch v2.1

My braille display is too small to actually take advantage of the feature, since the semantic and text info for the current node take up all the space and even require me to pan left and right to see it all, but this looks like it's a good set of changes. I also don't see any negative impact for speech.

Comment 6

[Marco Zehe (:MarcoZ)]

I believe with the move to more native Android support, that also comes with BrailleBack, so we probably no longer even use the code that was originally implemented to make braille output work. Eitan or Jamie, please reopen if you think this still needs work of some sort after the native refactor.

Comment 7

[James Teh [:Jamie]]

You're correct: we no longer use that code. Since the move to native, BrailleBack should be able to traverse the tree normally to get what it needs. That said, I'm unclear as to the "user scenario" for this bug. What was the problem we were trying to solve from a user perspective? It's possible we'll never know now.

Comment 8

[Marco Zehe (:MarcoZ)]

I believe -- and I may be wrong on that -- that this was meant to fill up spacing of the braille display with surrounding elements, like the one to the left or right, or possibly above and below.