873416 - Problem with beginElement & endElement in SVG Animation

Status: RESOLVED INVALID

(Core :: SVG, defect)

Description

[Manu]

User Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:18.0) Gecko/20100101 Firefox/18.0 (Beta/Release)
Build ID: 20130116073211

Steps to reproduce:

I have a web page where i used SVG. I wanted to animate SVG element from java script.

I created AnimateTransform DOM object in Java script and appended it to the SVG element.


Actual results:

Now, I called beginElement on AnimateTransform DOM object. It worked fine but, if i call endElement soon after beginElement it is supposed to stop animation. in fact it ignores the endElement. And this is vice verse if i call begin immediately after end begin is ignored.


Expected results:

begin or end shouldn't be ignored.

Comment 1

[Manu]

If i try debugging by putting breakpoints on begin & end it works well.

Comment 2

[Robert Longson [:longsonr]]

Please attach a testcase to this bug unless by comment 2 you're saying the bug is invalid?

Comment 3

[Manu]

Attachment: Testcase for the above problem.

Testcase for the above problem

Comment 4

[Manu]

(In reply to Robert Longson from comment #2)
> Please attach a testcase to this bug unless by comment 2 you're saying the
> bug is invalid?

Hi Robert thanks for the reply...

I have attached the testcase. PFA..

Comment 5

[Robert Longson [:longsonr]]

beginElement() is short for beginElementAt(0)
endElement() is short for endElementAt(0)

The first call starts the animation at time 0. I.e. immediately

The second call stops the animation at time 0 but that is now in the past as the animation started when beginElement() was called. Per http://www.w3.org/TR/2001/REC-smil-animation-20010904/#ResettingElementState any times in the past are ignored.

Opera works this way as does Chrome. Any UA that doesn't is invalid and you should raise a bug on that instead.

Comment 6

[Cameron McCormack (:heycam)]

And if you do want the element to end now, you can use:

  animationElt.endElement(document.documentElement.getCurrentTime());

Alternatively, you can remove the animation element from the DOM, which will also stop it.

Comment 7

[Robert Longson [:longsonr]]

I think Cameron meant endElementAt

Comment 8

[Manu]

(In reply to Robert Longson from comment #5)
> beginElement() is short for beginElementAt(0)
> endElement() is short for endElementAt(0)
> 
> The first call starts the animation at time 0. I.e. immediately
> 
> The second call stops the animation at time 0 but that is now in the past as
> the animation started when beginElement() was called. Per
> http://www.w3.org/TR/2001/REC-smil-animation-20010904/#ResettingElementState
> any times in the past are ignored.
> 
> Opera works this way as does Chrome. Any UA that doesn't is invalid and you
> should raise a bug on that instead.

Hi Robert..
 if endElement is short for endElementAt(0). I tried the below update on the attached testcase.

animate.beginElement();
function stop(){animate.endElement();}
setTimeout(stop,1000);

So according your theory endElement should be ignored. In fact animation is stopped after 1s.

And coming to chrome browser it doesn't animate for the attached testcase. But if i call beginElement->endElement->beginElement it suppose to restart animation but it doesn't. if i use beginElement -> endElement -> 1ms delay -> beginElement it works well. In chrome if i add 1ms delay b/w each of these it works smoothly.

Comment 9

[Manu]

(In reply to Cameron McCormack (:heycam) from comment #6)
> And if you do want the element to end now, you can use:
> 
>   animationElt.endElement(document.documentElement.getCurrentTime());
> 
> Alternatively, you can remove the animation element from the DOM, which will
> also stop it.

Hi Cameron thanks for the reply...
 I'm getting the below error.
TypeError: document.documentElement.getCurrentTime is not a function 

 And about your alternative suggestion. I wish to reuse already existing animation by just changing values and calling beginElement. Otherwise i have to create every time i need animation.

Comment 10

[Robert Longson [:longsonr]]

The interval 0 to 1 seconds as defined by the 

function stop(){animate.endElement();}
setTimeout(stop,1000);

call is a valid interval. Your original testcase with an interval of 0 - 0 seconds is not valid. 

Per http://www.w3.org/TR/2001/REC-smil-animation-20010904/#IntervalTiming the end time must be strictly after the begin time.

Comment 11

[Manu]

Chrome doesn't animate the attached testcase but firefox does. What is the reason? why it is not consistent?

Comment 12

[Robert Longson [:longsonr]]

Chrome has a bug: http://code.google.com/p/chromium/issues/detail?id=122846

Comment 13

[Manu]

Hi Robert
     Since 1s is bigger delay for our scenario, I tried with a smaller interval of 5ms, i.e.

function stop(){animate.endElement();}
setTimeout(stop,5);

With this, the result in firefox is observed to be inconsistent, as I try refreshing the page multiple times (sometimes it stops animating and other times it doesn't).

Comment 14

[Robert Longson [:longsonr]]

There is a minimum duration that we support. We have bug 733744 open to look into that.