Configure hg.ecmascript.org to link to bugs.ecmascript.org

RESOLVED FIXED

Status

RESOLVED FIXED
5 years ago
4 years ago

People

(Reporter: ted, Assigned: bkero)

Tracking

Details

I pushed a fix to our buglink Hg extension in bug 873227 so that we can configure the bugzilla instance that a hgweb links to. Now we need to configure hg.ecmascript.org to link to bugs.ecmascript.org. This is just a matter of putting the following in a hgrc somewhere:

[buglink]
bugzilla = https://bugs.ecmascript.org/show_bug.cgi?id=

If hg.ecmascript.org is hosted separately from hg.mo then you can put that in a global config, otherwise you can put that in .hg/hgrc for each specific repo, I think.

Updated

5 years ago
Assignee: server-ops-devservices → bkero
(Assignee)

Comment 1

5 years ago
I've updated the script (by running hg update on /repo/hg/mozilla/hgcustom/pushlog and copying buglink.py to /repo/hg/libraries/extensions and /repo/hg_ecma/libraries/extensions).

Since ecma shares infrastructure with the rest of our hg repositories, I've had to add the buglink hgrc stanza to all the repositories.
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED

Comment 2

5 years ago
This does not appear to be fixed as the url is still pointing to bmo and not bugs.ecmascript.org for hg.ecmascript.org repos.

ie. http://hg.ecmascript.org/tests/test262/rev/e62e1b35f0d9
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
(Assignee)

Comment 3

5 years ago
I've overwritten the extension parameter in the file as well. Reading the buglink.py script it seems that bugzilla.mozilla.org is still hardcoded in a few places.

Ted, could you make sure that this is the correct version and doublecheck that the revised code is correct?

903e0baea09b6f2471bfe4f7095cba5c  buglink.py
(Assignee)

Updated

5 years ago
Flags: needinfo?(ted)
(Assignee)

Comment 4

5 years ago
$ cat /repo/hg_ecma/mozilla/tests/test262/.hg/hgrc
[extensions]
buglinks = https://bugs.ecmascript.org/show_bug.cgi?id=

[buglink]
bugzilla = https://bugs.ecmascript.org/show_bug.cgi?id=
I don't see that revision in this repo anywhere:
http://hg.mozilla.org/hgcustom/pushlog/

The change I pushed was this:
http://hg.mozilla.org/hgcustom/pushlog/rev/d445a97d837d

(In reply to Ben Kero [:bkero] from comment #4)
> $ cat /repo/hg_ecma/mozilla/tests/test262/.hg/hgrc
> [extensions]
> buglinks = https://bugs.ecmascript.org/show_bug.cgi?id=

This is not right.

> [buglink]
> bugzilla = https://bugs.ecmascript.org/show_bug.cgi?id=

This should work.

The code WFM locally running "hg serve" in a repo with this extension enabled and adding the setting in .hg/hgrc, but that's not exactly equivalent to the hgwebdir setup on hg.mo, so it's certainly possible it doesn't work right there.
Flags: needinfo?(ted)
(Assignee)

Comment 6

5 years ago
The checksum was an md5sum of the file, not a revision in the repository.

The circumstances for the published hg copy are:

/etc/mercurial/hgrc:
[extensions]
buglink = /repo/hg/extensions/buglink.py

/repo/hg_ecma/mozilla/tests/test262/.hg/hgrc:
[root@hgssh1.dmz.scl3 .hg]# cat hgrc
[buglink]
bugzilla = https://bugs.ecmascript.org/show_bug.cgi?id=
(Assignee)

Comment 7

5 years ago
However I can confirm that hg serve and curling it returns the correct bugs.ecmascript.org reference.

Comment 8

5 years ago
both curl and wget show me the bugs.mozilla.org url in the file.

$ curl -O http://hg.ecmascript.org/tests/test262/rev/e62e1b35f0d9
$ grep -o "bugzilla.mozilla.org" e62e1b35f0d9 | wc -l
       2  // two occurrences 


Caching?
When I look at the page (having never looked at it before), it links me to the ecmascript Bugzilla instance, so I think this is fixed (and any caching issues have expired).
Status: REOPENED → RESOLVED
Last Resolved: 5 years ago5 years ago
Resolution: --- → FIXED

Comment 10

5 years ago
Agreed, I see the correct link now.  Thanks!
Component: Server Operations: Developer Services → General
Product: mozilla.org → Developer Services
You need to log in before you can comment on or make changes to this bug.