Closed
Bug 873464
Opened 12 years ago
Closed 11 years ago
(Australis) OS X Tab label needs vertical adjustments
Categories
(Firefox :: Theme, defect)
Tracking
()
RESOLVED
FIXED
Firefox 28
People
(Reporter: morpheus3k+bugzilla, Assigned: MattN)
References
()
Details
(Whiteboard: [Australis:M7])
Attachments
(2 files)
|
24.47 KB,
image/jpeg
|
Details | |
|
696 bytes,
patch
|
shorlander
:
review+
|
Details | Diff | Splinter Review |
Tab label difference
The design specs of Australis shows that the tab label and the close button are vertical aligned. In the currenct UX build the text a few pixel down.
I've attached a screenshot for comparison.
|
Reporter | |
Updated•12 years ago
|
Blocks: australis-tabs-osx
|
||
Updated•12 years ago
|
Whiteboard: [Australis:M?]
|
Assignee | |
Comment 1•12 years ago
|
||
I thought I got this right in bug 826689 by overlaying the mockup on my screenshot but I believe that's because I used the live mockup as the reference and it differs from the image mockup.
Stephen, which mockup is correct? If the image is correct, extra bonus points for fixing the live mockup :)
Flags: needinfo?(shorlander)
Hardware: x86 → All
|
|
Reporter | |
Comment 2•12 years ago
|
||
I've seen in the meeting notes a link to a recent design spec:
http://people.mozilla.com/~shorlander/files/australis-design-specs/australis-design-specs-osx.html
Maybe this helps.
|
||
Comment 3•12 years ago
|
||
(In reply to Matthew N. [:MattN] from comment #1)
> I thought I got this right in bug 826689 by overlaying the mockup on my
> screenshot but I believe that's because I used the live mockup as the
> reference and it differs from the image mockup.
> Stephen, which mockup is correct? If the image is correct, extra bonus
> points for fixing the live mockup :)
Unfortunately getting Photoshop text to line up exactly with platform text is not exact :)
If we move it up 1px on UX it should be about right.
Flags: needinfo?(shorlander)
|
|
Assignee | |
Comment 4•12 years ago
|
||
Okie doke
Assignee: nobody → mnoorenberghe+bmo
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
Whiteboard: [Australis:M?] → [Australis:M7]
|
|
Assignee | |
Comment 5•11 years ago
|
||
Despite the fact that the margin value is changing by 2px, it's only visually shifting by 1px.
Attachment #763178 -
Flags: review?(shorlander)
|
|
||
Comment 6•11 years ago
|
||
Comment on attachment 763178 [details] [diff] [review]
v.1 Move tab label up 1px
Review of attachment 763178 [details] [diff] [review]:
-----------------------------------------------------------------
Looks good to me. Thanks!
Attachment #763178 -
Flags: review?(shorlander) → review+
|
|
||
Comment 7•11 years ago
|
||
Removing the items from M7 that do not block landing on m-c.
Whiteboard: [Australis:M7] → [Australis:M?]
|
|
Assignee | |
Comment 8•11 years ago
|
||
Whiteboard: [Australis:M?] → [Australis:M7][fixed-in-ux]
|
||
Comment 9•11 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Whiteboard: [Australis:M7][fixed-in-ux] → [Australis:M7]
Target Milestone: --- → Firefox 28
You need to log in
before you can comment on or make changes to this bug.
Description
•