Closed Bug 873508 Opened 11 years ago Closed 8 years ago

[Messages][Refactoring] Refactor ThreadUI message & header rendering methods

Categories

(Firefox OS Graveyard :: Gaia::SMS, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::SMS
Platform:
ARM
Gonk (Firefox OS)
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED INVALID

People

(Reporter: gnarf, Unassigned)

References

Details

This section of code in ThreadUI is quickly becoming unmaintainable.  Multiple people have solved the same problems in different ways inside the code base, and this should really be abstracted out into a Message object that acts a bit like a map.

The Message will need to be able to render SMS and MMS messages, place it correctly in the active DOM, and deal with placing it inside the proper headers lists.
Assignee: nobody → gnarf37
Blocks: 868218
blocking-b2g: --- → leo+
Whiteboard: [NO_UPLIFT]
No longer blocks: 868218
leo- for now again, not using it for fixing 868218 - it got way uglier inside here than I thought it would
blocking-b2g: leo+ → ---
Whiteboard: [NO_UPLIFT]
I wonder if the existing Threads object is not already what we want here ?
I was modeling something VERY similar for Messages - I'll show it to ya one day soon.  It can be dusted off and made to work, but it was more work than I wanted to try to fix a simpler bug, considering how crazy our render methods are right now.
Assignee: gnarf37 → nobody
OS: Mac OS X → Gonk (Firefox OS)
Hardware: x86 → ARM
Blocks: sms-refactoring
Summary: [SMS] Refactor ThreadUI message & header rendering methods → [Messages][Refactoring] Refactor ThreadUI message & header rendering methods
I think our rendering is somewhat better now (even if not perfect), let's continue improving it by more precise bugs.
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → INVALID
You need to log in before you can comment on or make changes to this bug.