873511 - [Dialer] Clicking tel: link does not populate full phone number in Dialer

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Dialer, defect)

Description

[Ben Kelly [:bkelly, not reviewing]]

Gaia Branch: v1-train
Gaia Rev:  dfcf9b6d37c297360676bc796ed68984fdc1ca26
Gecko Branch: b2g18
Gecko Rev: 119395:4b5fe47ad76c
Hardware: Unagi

Clicking a tel: link in the browser will open the Dialer, but will not fully populate the number.  Only the area code will be populated.

To reproduce:

1) Search on Bing for: Mozilla Mountain View CA
2) Click the phone number box in the first result: [phone]
3) Dialer opens with only (650) populated.

(Note, trying this in google results in a 404.  I assume this is because they are using something other than a tel: link.)

Comment 1

[Ben Kelly [:bkelly, not reviewing]]

Note, clicking a phone number in the SMS app does populate the dialer correctly.

Comment 2

[Mihai Cirlanaru [:mihai][:mcirlanaru]]

Attachment: Add whitespace separator for 'tel:' parsing

Apparently this can't be fixed on Gaia's side since 'tel:' link parsing is done in Gecko -- this patch takes care of the fix there.

Comment 3

[Mihai Cirlanaru [:mihai][:mcirlanaru]]

Comment on attachment 776080 [details] [diff] [review]
Add whitespace separator for 'tel:' parsing

Review of attachment 776080 [details] [diff] [review]:
-----------------------------------------------------------------

Not sure who to ask for review here, but since you are one of the owners of the Gecko B2G Runtime I'm directing this to you Fabrice.

Comment 4

[[:fabrice] Fabrice Desré]

Comment on attachment 776080 [details] [diff] [review]
Add whitespace separator for 'tel:' parsing

Review of attachment 776080 [details] [diff] [review]:
-----------------------------------------------------------------

Section 2.5.3 of https://www.ietf.org/rfc/rfc2806.txt says that space should not be used has a visual separator, but since we find some in the wild...

Comment 5

[Mihai Cirlanaru [:mihai][:mcirlanaru]]

Thanks for checking this out Fabrice! Feel free to merge the patch.

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/projects/birch/rev/3ccb29418bfc

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/3ccb29418bfc