Closed Bug 873591 Opened 7 years ago Closed 6 years ago
Add line numbers/filenames to JS scripts we evaluate
For clearer error reporting when we're executing JS code, we might be able to take advantage of the optional arguments to evalInSandbox(https://developer.mozilla.org/en-US/docs/Components.utils.evalInSandbox#Optional_Arguments), so we can pinpoint the line that's causing the JS exception. Source for evalInSandbox if necessary: http://mxr.mozilla.org/mozilla-central/source/js/xpconnect/src/XPCComponents.cpp#3833
Any chance of this landing sometime soon?
I'll take care of it in the next day or two.
Assignee: nobody → jgriffin
Pushed to try: https://tbpl.mozilla.org/?tree=Try&rev=5c7c8b495762. Will flag for review if those goes green.
Add missing changes to marionette.py, document parameters to createStackMessage. I don't really like that this has a copy of createStackMessage in both -listeners.js and -server.js, but we don't have a good place to share code between the two right now. I guess we could create a marionette-common.js that gets loaded by both, what do you think?
Attachment #765578 - Flags: review?(mdas)
Attachment #765578 - Flags: review?(mdas) → review+
(In reply to Jonathan Griffin (:jgriffin) from comment #5) > I guess we could create a marionette-common.js that gets loaded by both, what do you think? Oh sorry, I missed this. Sounds like it would useful enough for this case alone, so we don't need to maintain it in two files.
https://hg.mozilla.org/integration/mozilla-inbound/rev/086b4d0b6cc6 I'm going to ticket marionette-common.js separately.
Target Milestone: --- → mozilla24
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.