Closed
Bug 873646
Opened 12 years ago
Closed 12 years ago
tutorial search needs small updates for changes in the makerapi, and an npm update
Categories
(Webmaker Graveyard :: Popcorn Maker, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: thecount, Assigned: thecount)
Details
Attachments
(1 file)
When something comes back from the makeapi:
It no longer has a .hits in the result (yay!)
Also thimble publishes makes encoded so tags don't think urls are app tags.
We should update how we search to account for that.
npm install update make to version 0.1.5.
|
Assignee | |
Updated•12 years ago
|
Assignee: nobody → scott
|
|
Assignee | |
Comment 1•12 years ago
|
||
Attachment #751204 -
Flags: review?(schranz.m)
Attachment #751204 -
Flags: review?(chris)
|
||
Comment 2•12 years ago
|
||
Comment on attachment 751204 [details] [review]
https://github.com/mozilla/popcorn.webmaker.org/pull/15
Yeah, this is good to go.
Attachment #751204 -
Flags: review?(chris) → review+
|
|
Assignee | |
Comment 3•12 years ago
|
||
Staged: https://github.com/mozilla/popcorn.webmaker.org/commit/2e8e4353b9894220eabcc38fd14485f1bf7daceb
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
|
||
Updated•12 years ago
|
Attachment #751204 -
Flags: review?(schranz.m)
|
||
Updated•11 years ago
|
Attachment mime type: text/plain → text/x-github-pull-request
You need to log in
before you can comment on or make changes to this bug.
Description
•