Clean up certificate_status message processing in libssl

RESOLVED FIXED in 3.15

Status

NSS
Libraries
P2
trivial
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: briansmith, Assigned: briansmith)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

Created attachment 751238 [details] [diff] [review]
Clean up certificate_status message processing in libssl

(In reply to Robert Relyea from Bug #360420 comment #153)
> Comment on attachment 701823 [details] [diff] [review]
> round 36 - patch 1 of 4 - client SSL protocol code
> 
> r+ I would like a separate patch to address the ssl state macine issue, but
> lets get this clear first.
> 
> brian- my complaint is the patch dies not follow how the ssl state machine
> works today I'm sympathetic to you woories, but adding and unexpected
> methode for handling optional messages were there us already an existing
> method has even more dangers. We should not put state machine desogn changes
> in peicemeal.

This patch does that. I think it also clarifies some of the issues rsleevi found when reviewing the code when Google imported it into Chromium.
Attachment #751238 - Flags: review?(wtc)
This isn't strictly necessary for 3.15 because it doesn't change any behavior (AFAICT). But, it might be nice to put it in 3.15 so that all the changes for the implementation of OCSP stapling land in the same release.
Target Milestone: --- → 3.15
Assignee: nobody → bsmith
Status: NEW → ASSIGNED

Comment 2

5 years ago
Comment on attachment 751238 [details] [diff] [review]
Clean up certificate_status message processing in libssl

Review of attachment 751238 [details] [diff] [review]:
-----------------------------------------------------------------

r=wtc. Thanks.
Attachment #751238 - Flags: review?(wtc) → review+

Comment 3

5 years ago
Created attachment 752492 [details] [diff] [review]
Clean up certificate_status message processing in libssl, v2

I folded the long comment lines and checked this in.

https://hg.mozilla.org/projects/nss/rev/722814555d1d
Attachment #751238 - Attachment is obsolete: true
Attachment #752492 - Flags: checked-in+

Updated

5 years ago
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Priority: -- → P2
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.