Closed Bug 873673 Opened 8 years ago Closed 8 years ago

Clean up certificate_status message processing in libssl

Categories

(NSS :: Libraries, defect, P2)

3.15
defect

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: briansmith, Assigned: briansmith)

References

Details

Attachments

(1 file, 1 obsolete file)

(In reply to Robert Relyea from Bug #360420 comment #153)
> Comment on attachment 701823 [details] [diff] [review]
> round 36 - patch 1 of 4 - client SSL protocol code
> 
> r+ I would like a separate patch to address the ssl state macine issue, but
> lets get this clear first.
> 
> brian- my complaint is the patch dies not follow how the ssl state machine
> works today I'm sympathetic to you woories, but adding and unexpected
> methode for handling optional messages were there us already an existing
> method has even more dangers. We should not put state machine desogn changes
> in peicemeal.

This patch does that. I think it also clarifies some of the issues rsleevi found when reviewing the code when Google imported it into Chromium.
Attachment #751238 - Flags: review?(wtc)
This isn't strictly necessary for 3.15 because it doesn't change any behavior (AFAICT). But, it might be nice to put it in 3.15 so that all the changes for the implementation of OCSP stapling land in the same release.
Target Milestone: --- → 3.15
Assignee: nobody → bsmith
Status: NEW → ASSIGNED
Comment on attachment 751238 [details] [diff] [review]
Clean up certificate_status message processing in libssl

Review of attachment 751238 [details] [diff] [review]:
-----------------------------------------------------------------

r=wtc. Thanks.
Attachment #751238 - Flags: review?(wtc) → review+
I folded the long comment lines and checked this in.

https://hg.mozilla.org/projects/nss/rev/722814555d1d
Attachment #751238 - Attachment is obsolete: true
Attachment #752492 - Flags: checked-in+
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Priority: -- → P2
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.