873693 - Download symbols and pass their location to the jetpack test harness

Status: RESOLVED WONTFIX

(Release Engineering :: General, defect)

Description

[Dave Townsend [:mossop]]

In order to fix bug 873204 we'll need to have the two places where jetpack tests are run by buildbot include some step to download the symbols and pass their path to the test harness.

Comment 1

[(not currently active) Ted Mielczarek]

FYI downloading the symbols is no longer required, you simply pass the URL in the symbol path and it's downloaded on-demand.

Comment 2

[Dave Townsend [:mossop]]

Ok good to know, so we just need to pass the symbol url to the jetpack harness

Comment 3

[Dave Townsend [:mossop]]

Unless there is some way to predict it from the Firefox build?

Comment 4

[(not currently active) Ted Mielczarek]

All the other harnesses have it passed in as a --symbols-path argument from buildbot or mozharness.

Comment 5

[Phil Ringnalda (:philor)]

In the case of not-the-Jetpack-tree, no sweat, if you look at a log you'll see it's already doing a "set props: symbols_url" buildstep, so it's already available to pass through.

For the Jetpack tree, it's predictable, just sort of tacky, replace .dmg|.zip|.tar.bz2 with crashreporter-symbols.zip in the path of the build you download, since the symbols for http://ftp.mozilla.org/pub/mozilla.org/firefox/tinderbox-builds/mozilla-central-linux64/1368826242/firefox-24.0a1.en-US.linux-x86_64.tar.bz2 are at http://ftp.mozilla.org/pub/mozilla.org/firefox/tinderbox-builds/mozilla-central-linux64/1368826242/firefox-24.0a1.en-US.linux-x86_64.crashreporter-symbols.zip.

Fortunately, touching the code that downloads the build in http://mxr.mozilla.org/build/source/tools/buildfarm/utils/run_jetpack.py already requires that you abandon all dignity, so the tackiness isn't that big a deal. Horribly fragile, since nobody will remember that any change in the naming of symbols files will require changing that, but again, it's already horribly fragile.

Comment 6

[(not currently active) Ted Mielczarek]

On the plus side, symbol package names are based on the package basename anyway, so it's unlikely to ever break:
http://mxr.mozilla.org/mozilla-central/source/toolkit/mozapps/installer/package-name.mk#128

Comment 7

[(not currently active) Ted Mielczarek]

I assume this will be (or already is) fixed by bug 1035512?

Comment 8

[Dave Townsend [:mossop]]

Yes

Comment 9

[Dave Townsend [:mossop]]

No longer needed now mochitest-jetpack is running