873702 - [Email] HTML tags containing attributes without separating/delimiting whitespace will be emitted as text by the HTML sanitizer (bleach.js)

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::E-Mail, defect, P1)

Description

[Leo]

1. Title : HTML Parsing Errors with images/ background from auto generated mails
2. Precondition : Email should be working and an IMAP account is configured
3. Tester's Action:  Launch Email -> Open any email such as received from Google+
4. Detailed Symptom (ENG.) : Some of the HTML contents related to background and Images are not rendered
5. Expected :All the content on email body should shown properly.
6.Reproducibility: Y
           1)Frequency Rate : 100%
7.Gaia Master/v1-train : Reproduced
8.Gaia Revision: 3c199e889364a0cc20f1b13a37eb309364a73de9
9.Personal email id:  [e-mail]

Comment 1

[psingapati]

eml contents are send to mail 

[e-mail].
Please check.

Comment 2

[psingapati]

Attachment: HTML content not parsed

Adding image that shows html content not parsed

Comment 3

[Andrew Sutherland [:asuth] (he/him)]

from IRC:

asuth: psingapati: I believe I've identified the problem.  There is a line like this:
asuth: <td style=3D="border-top:5px solid white;background-repeat:no-repeat;"background=3D"
asuth: er, where the '=' after that first =3D is a quoted-printable newline I elided
asuth: I think the lack of whitespace between the style tag and the "background" may be breaking the regex used by the HTML parser

Comment 4

[Leo]

As discussed in San Diego work week marking this as leo+.

Comment 5

[Andrew Sutherland [:asuth] (he/him)]

extra context: the html sanitizer lib is bleach.js, we're using the worker-thread-friendly branch:
https://github.com/asutherland/bleach.js/tree/worker-thread-friendly

The test/test-unclean.js test framework that process files in test/unclean and checks against test/unclear/expected.  The tests are run with mocha, you would want to do an "npm install" in the bleach.js dir, and then probably do an "npm install -g mocha" to get the mocha test runner on your path (or you can run it out of node_modules somehow? maybe 'npm' can help)?

The regex in question lives here:
https://github.com/asutherland/bleach.js/blob/worker-thread-friendly/lib/bleach.js#L350

I had tried to comment it a lot, but a lot of the regexp is inherited and I was just trying to document what it was doing.

Comment 6

[Andreas Gal :gal]

Andrew are you working on this or should we reassign?

Comment 7

[Andrew Sutherland [:asuth] (he/him)]

landed on gaia-email-libs-and-more/master:
https://github.com/mozilla-b2g/gaia-email-libs-and-more/pull/214
https://github.com/mozilla-b2g/gaia-email-libs-and-more/commit/b64dbe054cce60f4ccb30e7abf523b753c6961a8

landed on gaia/master:
https://github.com/mozilla-b2g/gaia/pull/10120
https://github.com/mozilla-b2g/gaia/commit/e73419a5353fedaa44bba4a03dcc6902098c250e

Comment 8

[John Ford [:jhford] CET/CEST Berlin Time]

Uplifted e73419a5353fedaa44bba4a03dcc6902098c250e to:
v1-train: 3aca920cdbffec4b438e94246cf25562257fbf69

Comment 9

[Andrew Sutherland [:asuth] (he/him)]

This would be hard for humans to test and the automated tests cover this.

Comment 10

[:CSchmoeckel]

Added Email Suite Test Case #8935 - [Email] HTML text & links are displayed properly in an e-mail IMAP account