87371 - Make size of prefs dialog localizable

Status: VERIFIED FIXED

(SeaMonkey :: Preferences, defect, P1)

Description

[Viswanath Ramachandran]

The prefs dialog is non-resizable and its width and height are hardcoded in the
XUL. This bug says to move the width and height to a dtd - so that localizers
can choose to change the dimensions for their locale if they so desire. We shd
do this on the mozilla trunk. 

This bug is not to make the dialog resizable.

Comment 1

[rossi]

i don't know what else it depends on, whether the content fits or not... but i
do have the us english version of the latest nightlies and for a long time now
the content of most preferences panes do not fit... so can't there be some other
issues than just the text that's in there that could make the content not fit?
and wouldn't it be best to make some automatic calculation and size the
preferences window so that everything fits?

Comment 2

[Ben Goodger (use ben at mozilla dot org for email)]

Attachment: patch to fix (branch & trunk)

Comment 3

[Viswanath Ramachandran]

Could you add a comment to localizers in the dtd so that they understand what to
do with that entity. with that r=vishy. 

Comment 4

[Ben Goodger (use ben at mozilla dot org for email)]

ok. hyatt sez 'sr=hyatt'

Comment 5

[Ben Goodger (use ben at mozilla dot org for email)]

comment reads:

<!-- LOCALIZATION NOTE : this is part of an inline-style attribute on the
     preference dialog's <window> node, which specifies the width and height
     in em units of the dialog. Increase these widths if you are having
     difficulty getting panel content to fit. 1em = the width of the 
     letter 'm' in the selected font -->

Comment 6

[Ben Goodger (use ben at mozilla dot org for email)]

chofmann has a'ed. checked in. 

Comment 7

[rchen]

Hi Ben, can you add the comment one line above the entity to tell the translator 
not to translate the terms like:

<!-- LOCALIZATION NOTE (prefWindow.size): DONT_TRANSLATE  "width:", "height:" 
and "em;" --> 
<!ENTITY  prefWindow.size             "width: 52em; height: 41em;">

Comment 8

[sairuh (rarely reading bugmail)]

rubberstamp.