SideMenuWidget shouldn't automatically scroll to bottom when there's a selected item

RESOLVED FIXED in Firefox 24

Status

()

Firefox
Developer Tools: Netmonitor
P3
normal
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: vporof, Assigned: vporof)

Tracking

unspecified
Firefox 24
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

Comment hidden (empty)
(Assignee)

Comment 1

5 years ago
Feature added in bug 863102, let's refine it a bit.
(Assignee)

Comment 2

5 years ago
Created attachment 751340 [details] [diff] [review]
v1
Assignee: nobody → vporof
Status: NEW → ASSIGNED
Attachment #751340 - Flags: review?(rcampbell)
(Assignee)

Comment 3

5 years ago
Created attachment 751341 [details] [diff] [review]
v1.1

Argh, typos, sorry!
Attachment #751340 - Attachment is obsolete: true
Attachment #751340 - Flags: review?(rcampbell)
Attachment #751341 - Flags: review?(rcampbell)
(Assignee)

Updated

5 years ago
Priority: -- → P3
(Assignee)

Comment 4

5 years ago
Green! https://tbpl.mozilla.org/?tree=Try&rev=f706348c697d
Comment on attachment 751341 [details] [diff] [review]
v1.1

Review of attachment 751341 [details] [diff] [review]:
-----------------------------------------------------------------

fine.

::: browser/devtools/netmonitor/test/browser_net_autoscroll.js
@@ +21,5 @@
>    // when the requests overflow the vertical size of the container.
>    .then(() => {
>      return waitForRequestsToOverflowContainer(monitor, requestsContainer);
> +  })
> +  .then(() => {

why the newlines, victor? why? You know I hate that.

@@ +52,5 @@
>    })
>  
> +  // (4) Now select an item in the list and check that additional requests
> +  // do not change the scroll position.
> +  .then(() => {

oh. so you can comment more easily, I guess. Still...
Attachment #751341 - Flags: review?(rcampbell) → review+
(Assignee)

Comment 6

5 years ago
https://hg.mozilla.org/integration/fx-team/rev/a018ebcf8b28
Whiteboard: [fixed-in-fx-team]
https://hg.mozilla.org/mozilla-central/rev/a018ebcf8b28
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 24
You need to log in before you can comment on or make changes to this bug.