873751 - Closing the requests details pane should deselect the currently selected item

Status: RESOLVED FIXED

(DevTools :: Netmonitor, defect, P3)

Description

[Victor Porof [:vporof][:vp]]

Two benefits:
1. Deselecting and scrolling to bottom wound ensure bug 863102 (automatically scrolling on new requests) still works.
2. Selecting the item again would reopen the details pane (currently, nothing happens on reselection).

Comment 1

[Victor Porof [:vporof][:vp]]

Attachment: v1

Comment 2

[Victor Porof [:vporof][:vp]]

Green! https://tbpl.mozilla.org/?tree=Try&rev=f706348c697d

Comment 3

[Rob Campbell [:rc] (:robcee)]

Comment on attachment 751348 [details] [diff] [review]
v1

Review of attachment 751348 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/devtools/netmonitor/netmonitor-view.js
@@ +1061,5 @@
>  
>    /**
>     * The mouse down listener for this container.
>     */
> +  _onMouseDown: function({ target }) {

you are destructuring stuff like nobody's business.

@@ +1072,5 @@
>  
>    /**
>     * The selection listener for this container.
>     */
> +  _onSelect: function({ detail: item }) {

no object is safe!

Comment 4

[Victor Porof [:vporof][:vp]]

https://hg.mozilla.org/integration/fx-team/rev/4f0d0d4018ee

Comment 5

[Tim Taubert [:ttaubert] (inactive)]

https://hg.mozilla.org/mozilla-central/rev/4f0d0d4018ee