Add assert to ~nsCycleCollector() that mRunner is null

RESOLVED FIXED in mozilla24

Status

()

Core
XPCOM
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: mccr8, Assigned: mccr8)

Tracking

unspecified
mozilla24
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
If you forget to call shutdown threads, mRunner is non-null when you destroy the collector, and you get a small leak.  With the assertion, this is easier to diagnose.

MOZ_ASSERT(!mRunner, "Destroying cycle collector without destroying its runner, may leak");
(Assignee)

Comment 1

5 years ago
Created attachment 751750 [details] [diff] [review]
assert
Attachment #751750 - Flags: review?(khuey)
https://hg.mozilla.org/mozilla-central/rev/2741e5cccc8c
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla24
You need to log in before you can comment on or make changes to this bug.