873764 - Add assert to ~nsCycleCollector() that mRunner is null

Status: RESOLVED FIXED

(Core :: XPCOM, defect)

Description

[Andrew McCreight [:mccr8]]

If you forget to call shutdown threads, mRunner is non-null when you destroy the collector, and you get a small leak.  With the assertion, this is easier to diagnose.

MOZ_ASSERT(!mRunner, "Destroying cycle collector without destroying its runner, may leak");

Comment 1

[Andrew McCreight [:mccr8]]

Attachment: assert

Comment 2

[Andrew McCreight [:mccr8]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/2741e5cccc8c

Comment 3

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/2741e5cccc8c