Closed Bug 873798 Opened 9 years ago Closed 8 years ago

Create directory for global build system and mach state

Categories

(Firefox Build System :: General, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
mozilla24

People

(Reporter: gps, Assigned: gps)

Details

(Whiteboard: [mach])

Attachments

(1 file)

As written at https://groups.google.com/forum/?fromgroups#!topic/mozilla.dev.platform/1EIlJAvIO-0 I'd like to create a global directory for storing build system and mach state. Patch forthcoming.
I added code to the mach bootstrap flow to check for and create a global state directory if it doesn't exist. Currently, we do nothing with this directory, but that will soon change. One of the first things I plan to hook up is a periodic check for whether bootstrap has recently been performed.

Eventually, I could see this code moving into the mach core. But, let's start with something quick and dirty.

I imagine most of this review will be answering the question "is this a good idea." As I've laid out in the dev.platform post, I think it is. If you have doubts, I can give many more ideas to help sway you :)
Assignee: nobody → gps
Status: NEW → ASSIGNED
Attachment #751400 - Flags: review?(ted)
Comment on attachment 751400 [details] [diff] [review]
Create state directory when mach is ran, v1

Review of attachment 751400 [details] [diff] [review]:
-----------------------------------------------------------------

::: build/mach_bootstrap.py
@@ +135,5 @@
> +            print(STATE_DIR_FIRST_RUN.format(userdir=state_user_dir))
> +            try:
> +                for i in range(20, -1, -1):
> +                    time.sleep(1)
> +                    print('%d ' % i, end='')

This should probably just be sys.stdout.write.

::: js/xpconnect/tests/idl/Makefile.in
@@ +12,5 @@
>  
>  include $(topsrcdir)/config/rules.mk
>  
>  componentdir = js/xpconnect/tests/components
> +libs:: $(DEPTH)/_idl/xpt/$(MODULE).xpt

This seems irrelevant.
Attachment #751400 - Flags: review?(ted) → review+
https://hg.mozilla.org/mozilla-central/rev/69a8f7b3a2e2
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.