undefined reference to 'vtable for mozilla::CameraPreviewFrameCallback'

RESOLVED FIXED in mozilla24

Status

()

Core
WebRTC
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: slee, Assigned: slee)

Tracking

unspecified
mozilla24
ARM
Gonk (Firefox OS)
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [WebRTC][blocking-webrtc-][b2g-webrtc+][qa-])

Attachments

(1 attachment, 1 obsolete attachment)

864 bytes, patch
slee
: review+
Details | Diff | Splinter Review
(Assignee)

Description

5 years ago
Created attachment 751545 [details] [diff] [review]
patch

On B2G, it has linking error as the following

../../../../unagi/prebuilt/linux-x86/toolchain/arm-linux-androideabi-4.4.x/bin/../lib/gcc/arm-linux-androideabi/4.4.3/../../../../arm-linux-androideabi/bin/ld: /home/mozalfredo/mozwork/mozilla-central-unagi/objdir-unagi/toolkit/library/../../content/media/webrtc/MediaEngineWebRTC.o: in function mozilla::CameraPreviewFrameCallback::CameraPreviewFrameCallback():/home/mozalfredo/mozwork/mozilla-centr
[11:18]  <alfredo> al-unagi/dom/camera/CameraPreviewMediaStream.h:14: error: undefined reference to 'vtable for mozilla::CameraPreviewFrameCallback'
(Assignee)

Updated

5 years ago
Attachment #751545 - Flags: review?(kchen)

Updated

5 years ago
Whiteboard: [WebRTC][blocking-webrtc-][b2g-webrtc+]

Updated

5 years ago
Attachment #751545 - Attachment is patch: true
Comment on attachment 751545 [details] [diff] [review]
patch

Review of attachment 751545 [details] [diff] [review]:
-----------------------------------------------------------------

r+, make it a pure virtual function.
Attachment #751545 - Flags: review?(kchen) → review+
(Assignee)

Comment 2

5 years ago
Created attachment 753655 [details] [diff] [review]
patch - v2
Attachment #751545 - Attachment is obsolete: true
Attachment #753655 - Flags: review+
(Assignee)

Updated

5 years ago
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/89eda39678bb
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla24

Updated

5 years ago
Whiteboard: [WebRTC][blocking-webrtc-][b2g-webrtc+] → [WebRTC][blocking-webrtc-][b2g-webrtc+][qa-]
You need to log in before you can comment on or make changes to this bug.