Closed
Bug 873919
Opened 9 years ago
Closed 9 years ago
[b2g-bluetooth] Remove old system messages for Bluetooth pairing requests
Categories
(Firefox OS Graveyard :: Bluetooth, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: gyeh, Assigned: gyeh)
References
Details
(Whiteboard: [fixed-in-birch])
Attachments
(1 file, 2 obsolete files)
Old system messages are combined into one new message typed "bluetooth-pairing-request", so they should be retired after Settings App migrates to new message (bug 873917).
Assignee | ||
Updated•9 years ago
|
Assignee: nobody → gyeh
Assignee | ||
Comment 1•9 years ago
|
||
Attachment #764514 -
Flags: review?(echou)
Comment 2•9 years ago
|
||
Comment on attachment 764514 [details] [diff] [review] Patch 1(v1): Remove old system messages for Bluetooth pairing requests Review of attachment 764514 [details] [diff] [review]: ----------------------------------------------------------------- ok, I can confirm that other stuff is good, but I'm not sure if the line I comment at is correct or not. Feedback? mrbkap since we need feedback from expert ;) ::: dom/bluetooth/BluetoothService.cpp @@ +756,3 @@ > > AutoSafeJSContext cx; > + JS::Rooted<JSObject*> obj(cx); Question: shouldn't it be JS::Rooted<JSObject*> obj(cx, JS_NewObject(cx, NULL, NULL, NULL))?
Attachment #764514 -
Flags: review?(echou)
Attachment #764514 -
Flags: review+
Attachment #764514 -
Flags: feedback?(mrbkap)
Assignee | ||
Comment 3•9 years ago
|
||
(In reply to Eric Chou [:ericchou] [:echou] (6/25 ~ 28 @ Shanghai, GSMA MAE) from comment #2) > ::: dom/bluetooth/BluetoothService.cpp > @@ +756,3 @@ > > > > AutoSafeJSContext cx; > > + JS::Rooted<JSObject*> obj(cx); > > Question: shouldn't it be JS::Rooted<JSObject*> obj(cx, JS_NewObject(cx, > NULL, NULL, NULL))? Agree. I think we should use |JS_NewObject(cx, nullptr, nullptr, nullptr)|. Or, obj would be a null pointer. Let me update patch and confirm with mrbkap :)
Assignee | ||
Comment 4•9 years ago
|
||
Attachment #764514 -
Attachment is obsolete: true
Attachment #764514 -
Flags: feedback?(mrbkap)
Attachment #764578 -
Flags: review?(echou)
Attachment #764578 -
Flags: feedback?(mrbkap)
Comment 5•9 years ago
|
||
Comment on attachment 764578 [details] [diff] [review] Patch 1(v2): Remove old system messages for Bluetooth pairing requests Review of attachment 764578 [details] [diff] [review]: ----------------------------------------------------------------- :)
Attachment #764578 -
Flags: review?(echou) → review+
Comment 6•9 years ago
|
||
Comment on attachment 764578 [details] [diff] [review] Patch 1(v2): Remove old system messages for Bluetooth pairing requests Yep, this is right.
Attachment #764578 -
Flags: feedback?(mrbkap) → feedback+
Assignee | ||
Comment 7•9 years ago
|
||
Thanks, mrbkap. :)
Assignee | ||
Comment 8•9 years ago
|
||
try: https://tbpl.mozilla.org/?tree=Try&rev=ccc959667915 https://tbpl.mozilla.org/?tree=Try&rev=d8b68528fe8e
Attachment #764578 -
Attachment is obsolete: true
Assignee | ||
Comment 9•9 years ago
|
||
https://hg.mozilla.org/projects/birch/rev/f2e3f99ec1d0
Whiteboard: [fixed-in-birch]
Comment 10•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/f2e3f99ec1d0
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•