873919 - [b2g-bluetooth] Remove old system messages for Bluetooth pairing requests

Status: RESOLVED FIXED

Description

[Gina Yeh [:gyeh] [:ginayeh]]

Old system messages are combined into one new message typed "bluetooth-pairing-request", so they should be retired after Settings App migrates to new message (bug 873917).

Comment 1

[Gina Yeh [:gyeh] [:ginayeh]]

Attachment: Patch 1(v1): Remove old system messages for Bluetooth pairing requests

Comment 2

[Eric Chou [:ericchou] [:echou]]

Comment on attachment 764514 [details] [diff] [review]
Patch 1(v1): Remove old system messages for Bluetooth pairing requests

Review of attachment 764514 [details] [diff] [review]:
-----------------------------------------------------------------

ok, I can confirm that other stuff is good, but I'm not sure if the line I comment at is correct or not. Feedback? mrbkap since we need feedback from expert ;)

::: dom/bluetooth/BluetoothService.cpp
@@ +756,3 @@
>  
>    AutoSafeJSContext cx;
> +  JS::Rooted<JSObject*> obj(cx);

Question: shouldn't it be JS::Rooted<JSObject*> obj(cx, JS_NewObject(cx, NULL, NULL, NULL))?

Comment 3

[Gina Yeh [:gyeh] [:ginayeh]]

(In reply to Eric Chou [:ericchou] [:echou] (6/25 ~ 28 @ Shanghai, GSMA MAE) from comment #2)
> ::: dom/bluetooth/BluetoothService.cpp
> @@ +756,3 @@
> >  
> >    AutoSafeJSContext cx;
> > +  JS::Rooted<JSObject*> obj(cx);
> 
> Question: shouldn't it be JS::Rooted<JSObject*> obj(cx, JS_NewObject(cx,
> NULL, NULL, NULL))?

Agree. I think we should use |JS_NewObject(cx, nullptr, nullptr, nullptr)|. Or, obj would be a null pointer.

Let me update patch and confirm with mrbkap :)

Comment 4

[Gina Yeh [:gyeh] [:ginayeh]]

Attachment: Patch 1(v2): Remove old system messages for Bluetooth pairing requests

Comment 5

[Eric Chou [:ericchou] [:echou]]

Comment on attachment 764578 [details] [diff] [review]
Patch 1(v2): Remove old system messages for Bluetooth pairing requests

Review of attachment 764578 [details] [diff] [review]:
-----------------------------------------------------------------

:)

Comment 6

[Blake Kaplan (:mrbkap) (inactive, use needinfo)]

Comment on attachment 764578 [details] [diff] [review]
Patch 1(v2): Remove old system messages for Bluetooth pairing requests

Yep, this is right.

Comment 7

[Gina Yeh [:gyeh] [:ginayeh]]

Thanks, mrbkap. :)

Comment 8

[Gina Yeh [:gyeh] [:ginayeh]]

Attachment: Patch 1: Remove old system messages for Bluetooth pairing requests, r=echou

try:

https://tbpl.mozilla.org/?tree=Try&rev=ccc959667915
https://tbpl.mozilla.org/?tree=Try&rev=d8b68528fe8e

Comment 9

[Gina Yeh [:gyeh] [:ginayeh]]

https://hg.mozilla.org/projects/birch/rev/f2e3f99ec1d0

Comment 10

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/f2e3f99ec1d0