873931 - [System][Statusbar] Statusbar does not show when fullscreen is canceled.

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::System, defect)

Description

[Leo]

1. Title : [System][Statusbar] Statusbar does not show when fullscreen is canceled.
2. Precondition : Run an app that has an option to turn fullscreen mode on/off.
3. Tester's Action : Turn fullscreen mode on and off.
4. Detailed Symptom (ENG.) : Observe the statusbar is not displayed. Instead, you can see through the homescrean background.
5. Expected : The statusbar should be displayed.
6.Reproducibility: Y
           1)Frequency Rate : 100%
7.Gaia Revision: a503d9a1d0a588f3689243c1ddc0f016ede51b9d
8.Personal email id:  [e-mail]

This is a regression from Bug 834765.

Comment 1

[Leo]

Attachment: repro steps

Comment 2

[Leo]

I only see this code in V1 train,

The fix is to change

      case 'appopen':
      case 'mozfullscreenchange':
      case 'unlock':
        if (this.screen.classList.contains('fullscreen-app') ||
            document.mozFullScreen) {
          this.hide();
        }

to

      case 'appopen':
      case 'mozfullscreenchange':
      case 'unlock':
        if (this.screen.classList.contains('fullscreen-app') ||
            document.mozFullScreen) {
          this.hide();
        } else {
          this.show();
        }

Comment 3

[Jason Smith [:jsmith]]

That's bad - we need to return to a clean state if we leave fullscreen. Regression from a leo+ blocker too.

Comment 4

[Leo]

Attachment: Patch

Requesting review. Thanks Alive.

Comment 5

[(inactive after 6/18) Alive Kuo [:alive]]

Comment on attachment 751563 [details] [diff] [review]
Patch

Review of attachment 751563 [details] [diff] [review]:
-----------------------------------------------------------------

r=alive, thanks leo for investigating and patching.

Comment 6

[[:fabrice] Fabrice Desré]

Is there any reason to not land this?

Comment 7

[(inactive after 6/18) Alive Kuo [:alive]]

leo, please create a pull request to merge, thanks.

Comment 8

[Leo]

(In reply to Alive Kuo [:alive] from comment #7)
> leo, please create a pull request to merge, thanks.

The reason why I didn't create a pull request was because I don't see the this.hide(); codes on master, but only on V1-train. 

https://github.com/mozilla-b2g/gaia/blob/master/apps/system/js/statusbar.js
https://github.com/mozilla-b2g/gaia/blob/v1-train/apps/system/js/statusbar.js

I tried to create a pull request against V1-train, but I couldn't. Let me try again now.

Comment 9

[Leo]

Attachment: Pull request url

Comment 10

[(inactive after 6/18) Alive Kuo [:alive]]

Comment on attachment 757803 [details]
Pull request url

r=me, I will merge for you.

Comment 11

[(inactive after 6/18) Alive Kuo [:alive]]

https://github.com/mozilla-b2g/gaia/commit/ed5cee06576544a99fa5a9612f64ede75b0b6913