Closed Bug 873971 Opened 11 years ago Closed 11 years ago

[Camera] Video thumbnail generation and filmstrip item deletion in camera app fail due to inconsistent filepath

Categories

(Firefox OS Graveyard :: Gaia::Camera, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::Camera
Platform:
ARM
Gonk (Firefox OS)
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(blocking-b2g:leo+, b2g18 fixed)

Status:
RESOLVED FIXED
Project Flags:
blocking-b2g leo+
Tracking Flags:
Tracking Status
b2g18 --- fixed

People

(Reporter: ben.tian, Assigned: ben.tian)

References

Details

(Keywords: regression, smoketest)

Attachments

(1 file, 1 obsolete file)

link to https://github.com/mozilla-b2g/gaia/pull/9896
180 bytes, patch
djf
: review+
Details | Diff | Splinter Review 
Composite storage changes file path of device storage event from relative path to fully-qualified one. But camera app still stores relative path to match file during video thumbnail generation and filmstrip item deletion.

For example, filmstrip stores file path DCIM/foo.jpg but device storage event returns /sdcard/DCIM/foo.jpg, and the mismatch fails filmstrip to delete correct item.
See Also: → 872170
Assignee: nobody → btian
Attached patch camera app absolute path (obsolete) — — Splinter Review 
A patch that uses absolute (fully-qualified) path for filmstrip and video thumbnail generation. Under testing.
Keywords: smoketest
What's the user impact? Is this a regression? Should this be a leo blocker?
blocking-b2g: --- → leo?
Keywords: regression, regressionwindow-wanted
Summary: Video thumbnail generation and filmstrip item deletion fail due to inconsistent filepath → [Camera] Video thumbnail generation and filmstrip item deletion in camera app fail due to inconsistent filepath
I filed bug 873303 to have video change the location of its previews, and I'm working on bug 873104.

Both of those bugs are probably related.
David, can you review the patch? It replaces relative path with absolute path (fully-qualified path) for filmstrip and video thumbnail generation.
Attachment #751624 - Attachment is obsolete: true
Attachment #752029 - Flags: review?(dflanagan)
Looks like we've got a patch here, so it sounds like we're unblocked to fix this (no longer need a regression window). If we end up still needing a regression window, feel free to flag the keyword again.
Keywords: regressionwindow-wanted
Comment on attachment 752029 [details] [diff] [review]
link to https://github.com/mozilla-b2g/gaia/pull/9896

This looks good. Thanks!
Attachment #752029 - Flags: review?(dflanagan) → review+
gaia master: https://github.com/mozilla-b2g/gaia/commit/f613af6ea475e7e58994cb72113b2ccfb7ba6b45
--

This bug has to be leo+ as bug 872170 (the composite storage change) is also leo+. Otherwise the recorded videos don't show in filmstrip nor in gallery.
Status: NEW → RESOLVED
Closed: 11 years ago
OS: Linux → Gonk (Firefox OS)
Hardware: x86_64 → ARM
Resolution: --- → FIXED
Discussed with DJF during MiniWW. Marking this leo+ and DJF will uplift it to V1-train.
blocking-b2g: leo? → leo+
Flags: in-moztrap-
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: