87405 - Change columns on stored query loses title.

Status: RESOLVED FIXED

(Bugzilla :: Query/Bug List, defect, P3)

Description

[Matthew Tuck [:CodeMachine]]

We have a nice snazzy title that appears on stored queries now.  Woohoo!

However, if you hit 'Change Columns' then it gets converted to a big query URL
and even though the query title seems to still be in the URL, the title no
longer appears on the page.  I believe it should.

It would probably be nice to fix this by just adding an ordering to the end and
not convert it to a big query URL.

Comment 1

[Matthew Tuck [:CodeMachine]]

And while you're in the area, please explain why the big URL has this:

"namedcmd=2.12+Bugzilla+Bugs&newqueryname=2.16+Bugzilla+Bugs"

"2.16 Bugzilla Bugs" is the relevant query, whereas "2.12 Bugzilla Bugs" is a
query I haven't had since ... well ... you know ...

Comment 2

[Christopher Aillon (sabbatical, not receiving bugmail)]

Mass moving to new product Bugzilla...

Comment 3

[Dave Miller [:justdave]]

We are currently trying to wrap up Bugzilla 2.16.  We are now close enough to
release time that anything that wasn't already ranked at P1 isn't going to make
the cut.  Thus this is being retargetted at 2.18.  If you strongly disagree with
this retargetting, please comment, however, be aware that we only have about 2
weeks left to review and test anything at this point, and we intend to devote
this time to the remaining bugs that were designated as release blockers.

Comment 4

[timeless]

*** Bug 89827 has been marked as a duplicate of this bug. ***

Comment 5

[Joel Peshkin]

These bugs appear to be abandoned.  Retargeting to 2.20

Comment 6

[Max Kanat-Alexander]

Anybody interested in fixing this? It sounds fairly simple.

Comment 7

[Frédéric Buclin]

Attachment: patch, v1

Comment 8

[Teemu Mannermaa (:wicked)]

Comment on attachment 202378 [details] [diff] [review]
patch, v1

>Index: template/en/default/list/list.html.tmpl
>===================================================================
>-[% title = "$terms.Bug List" %]
>-[% IF searchname %]
>-  [% title = title _ ": " _ searchname %]
>+[% title = BLOCK %]
>+  [% terms.Bug %] List: [% searchname || defaultsavename FILTER html %]

This adds a useless : to non-saved search bug list titles.

Is there are reason searchname was not filtered earlier? It's not clear to me if this patch makes it filtered or not.

I think it would be better to use OR instead of || because OR seems to be used later in the template.

Comment 9

[Frédéric Buclin]

Attachment: patch, v2

Comment 10

[Myk Melez [:myk] [@mykmelez]]

Low-risk polish fix. Suitable for checkin during release freeze.

Comment 11

[Frédéric Buclin]

Checking in template/en/default/list/list.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/list/list.html.tmpl,v  <--  list.html.tmpl
new revision: 1.42; previous revision: 1.41
done