874051 - (Australis) 2 remaining failing tests on UX in accessible/tests/mochitest/tree/test_tabbrowser.xul

Status: RESOLVED FIXED

(Firefox :: Tabbed Browser, defect)

Description

[:Gijs (he/him)]

Failures look like:


19:56:22 INFO - 24705 ERROR TEST-UNEXPECTED-FAIL | chrome://mochitests/content/a11y/accessible/tests/mochitest/tree/test_tabbrowser.xul | Different amount of expected children of ['tab node', address: [object XULElement], role: pagetab, name: 'About:', address: [xpconnect wrapped nsIAccessible]]. - got 3, expected 1

19:56:22 INFO - 24711 ERROR TEST-UNEXPECTED-FAIL | chrome://mochitests/content/a11y/accessible/tests/mochitest/tree/test_tabbrowser.xul | Different amount of expected children of ['tab node', address: [object XULElement], role: pagetab, name: 'The Book of Mozilla, 15:1', address: [xpconnect wrapped nsIAccessible]]. - got 2, expected 1

Comment 1

[:Gijs (he/him)]

Some investigating shows that this is because the :before and :after images show up in the a11y tree. I'm guessing these are the tab separator (where there's only 1 extra node) and the tab curves (where there's 2 extra nodes), respectively. Not sure how to get them to disappear from the a11y tree yet (of course we can adjust the test, but I suspect we should make sure they don't show up. Marco or David, have you got any idea how to affect generated content nodes from an a11y perspective? I can't very well put a role attribute on there... :-\

Comment 2

[:Gijs (he/him)]

At the suggestion of Marco, paging Alexander Surkov - any idea what to do about this? Refactoring and not using GC at this point is something I think we'd like to avoid, if possible...

Comment 3

[alexander :surkov (:asurkov)]

:before and :after are mapped into accessible tree. It seems you need to adjust test expectations for your platform.

Comment 4

[:Gijs (he/him)]

Attachment: Patch changing test expectations

Like this? :-)

Comment 5

[:Gijs (he/him)]

(Yes, I've tested this, it passes on my local machine on the UX branch, which is where this would land)

Comment 6

[alexander :surkov (:asurkov)]

what platform it fails on?

Comment 7

[:Gijs (he/him)]

(In reply to alexander :surkov from comment #6)
> what platform it fails on?

All of them (Linux, Mac, Windows). This is why I asked for info, but you told me I should just change the test's expectations...

Comment 8

[alexander :surkov (:asurkov)]

It doesn't fail on running tinderbox machines, right?

Comment 9

[:Gijs (he/him)]

(In reply to alexander :surkov from comment #8)
> It doesn't fail on running tinderbox machines, right?

It does. On the UX branch (Australis) we're changing the looks of the tabs. This has involved using some :before and :after images, which are now causing these failing a11y tests on this branch. We like green tests, and we can't land Australis on mozilla-central before the tests are green, so we're trying to make our tests green on the branch. The changes would then merge to mozilla-central whenever Australis lands (likely to be the beginning of the 25 cycle).

Comment 10

[:Gijs (he/him)]

See https://tbpl.mozilla.org/?tree=UX with eg.:

https://tbpl.mozilla.org/php/getParsedLog.php?id=23233679&tree=UX
https://tbpl.mozilla.org/php/getParsedLog.php?id=23233962&tree=UX
https://tbpl.mozilla.org/php/getParsedLog.php?id=23231387&tree=UX

(linux, mac and windows XP logs, respectively)

Comment 11

[alexander :surkov (:asurkov)]

Comment on attachment 752593 [details] [diff] [review]
Patch changing test expectations

Review of attachment 752593 [details] [diff] [review]:
-----------------------------------------------------------------

ok, got it. It looks ok.

Comment 12

[:Gijs (he/him)]

Thanks! Pushed to UX: http://hg.mozilla.org/projects/ux/rev/9443ce3837d5

Comment 13

[:Gijs (he/him)]

Green, green, wonderful green...

Comment 14

[Matthew N. [:MattN]]

Backed out in https://hg.mozilla.org/projects/ux/rev/727658cf86e0 as part of bug 857886 since we switched back to using background-image instead of content: url(…).