Closed Bug 874051 Opened 6 years ago Closed 6 years ago

(Australis) 2 remaining failing tests on UX in accessible/tests/mochitest/tree/test_tabbrowser.xul

Categories

(Firefox :: Tabbed Browser, defect)

defect
Not set

Tracking

()

RESOLVED FIXED

People

(Reporter: Gijs, Assigned: Gijs)

References

Details

(Whiteboard: [fixed-in-ux])

Attachments

(1 file)

Failures look like:


19:56:22 INFO - 24705 ERROR TEST-UNEXPECTED-FAIL | chrome://mochitests/content/a11y/accessible/tests/mochitest/tree/test_tabbrowser.xul | Different amount of expected children of ['tab node', address: [object XULElement], role: pagetab, name: 'About:', address: [xpconnect wrapped nsIAccessible]]. - got 3, expected 1

19:56:22 INFO - 24711 ERROR TEST-UNEXPECTED-FAIL | chrome://mochitests/content/a11y/accessible/tests/mochitest/tree/test_tabbrowser.xul | Different amount of expected children of ['tab node', address: [object XULElement], role: pagetab, name: 'The Book of Mozilla, 15:1', address: [xpconnect wrapped nsIAccessible]]. - got 2, expected 1
Some investigating shows that this is because the :before and :after images show up in the a11y tree. I'm guessing these are the tab separator (where there's only 1 extra node) and the tab curves (where there's 2 extra nodes), respectively. Not sure how to get them to disappear from the a11y tree yet (of course we can adjust the test, but I suspect we should make sure they don't show up. Marco or David, have you got any idea how to affect generated content nodes from an a11y perspective? I can't very well put a role attribute on there... :-\
At the suggestion of Marco, paging Alexander Surkov - any idea what to do about this? Refactoring and not using GC at this point is something I think we'd like to avoid, if possible...
Flags: needinfo?(surkov.alexander)
:before and :after are mapped into accessible tree. It seems you need to adjust test expectations for your platform.
Flags: needinfo?(surkov.alexander)
Like this? :-)
Attachment #752593 - Flags: review?(surkov.alexander)
(Yes, I've tested this, it passes on my local machine on the UX branch, which is where this would land)
what platform it fails on?
(In reply to alexander :surkov from comment #6)
> what platform it fails on?

All of them (Linux, Mac, Windows). This is why I asked for info, but you told me I should just change the test's expectations...
It doesn't fail on running tinderbox machines, right?
(In reply to alexander :surkov from comment #8)
> It doesn't fail on running tinderbox machines, right?

It does. On the UX branch (Australis) we're changing the looks of the tabs. This has involved using some :before and :after images, which are now causing these failing a11y tests on this branch. We like green tests, and we can't land Australis on mozilla-central before the tests are green, so we're trying to make our tests green on the branch. The changes would then merge to mozilla-central whenever Australis lands (likely to be the beginning of the 25 cycle).
Comment on attachment 752593 [details] [diff] [review]
Patch changing test expectations

Review of attachment 752593 [details] [diff] [review]:
-----------------------------------------------------------------

ok, got it. It looks ok.
Attachment #752593 - Flags: review?(surkov.alexander) → review+
Thanks! Pushed to UX: http://hg.mozilla.org/projects/ux/rev/9443ce3837d5
Whiteboard: [fixed-in-ux]
Green, green, wonderful green...
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Backed out in https://hg.mozilla.org/projects/ux/rev/727658cf86e0 as part of bug 857886 since we switched back to using background-image instead of content: url(…).
You need to log in before you can comment on or make changes to this bug.