874052 - Add a method to check if a compartment is in debug mode

Status: RESOLVED INCOMPLETE

(Core :: JavaScript Engine, defect, P3)

Description

[Mihai Sucan [:msucan]]

Follow-up from bug 865549: we need some Debugger API to check if a given compartment has any debugger attached. This is need to make sure we are not leaking debug-mode for content and browser windows.

Comment 1

[Rob Campbell [:rc] (:robcee)]

Would be nice to have.

Comment 2

[Jim Blandy :jimb]

That would be perfect on IJSDebugger:
js/ductwork/debugger/IJSDebugger.idl

I don't think it makes sense on Debugger, because it's more of a diagnostic API.

Comment 3

[Jim Blandy :jimb]

Note that there is already JS_GetDebugMode:
http://dxr.mozilla.org/mozilla-central/source/js/src/jsdbgapi.h#l130

Comment 4

[Rob Campbell [:rc] (:robcee)]

Mihai, does that satisfy your requirements? Can we close this?

Comment 5

[Mihai Sucan [:msucan]]

JS_GetDebugMode() is now in OldDebugAPI.h. Is this supported API? Is it scriptable / accessible from chrome-privileged JS? Thank you Jim!

Comment 6

[Jim Blandy :jimb]

It's not available via any JS-visible interface. We should add a method to IJSDebugger (and an implementation on JSDebugger) that calls it.

js/ductwork/debugger/IJSDebugger.idl
js/ductwork/debugger/JSDebugger.cpp