Closed Bug 874070 Opened 7 years ago Closed 7 years ago

SDK tests shouldn't check for <tab>'s load event but for browser's

Categories

(Add-on SDK Graveyard :: General, defect)

defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: Gijs, Unassigned)

References

Details

Attachments

(1 file)

See also eg. bug 874028.

In the SDK, offenders are the open functions in:

http://mxr.mozilla.org/mozilla-central/source/addon-sdk/source/test/addons/private-browsing-supported/test-selection.js

and 

http://mxr.mozilla.org/mozilla-central/source/addon-sdk/source/test/test-selection.js

(I don't know which is a copy of which and why there's two subtly different files there?)

Then the code here also seems like it'd be broken (deprecated, fortunately? What is its replacement?):

http://mxr.mozilla.org/mozilla-central/source/addon-sdk/source/lib/sdk/deprecated/tab-browser.js#556
Pointer to Github pull-request
Commits pushed to master at https://github.com/mozilla/addon-sdk

https://github.com/mozilla/addon-sdk/commit/df72c4b7fcd02ad789beea86c09fd6178ba0a8ea
Bug 874070 - Fix selection tests and tab-browser lib to listen for load events on <browser> rather than <tab>

https://github.com/mozilla/addon-sdk/commit/928bee438f792cfe181fab353a003184e5d3f309
Merge pull request #1002 from gijsk/bug874070

fix Bug 874070 - SDK tests shouldn't check for <tab>'s load event but for browser's r=@zer0
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Commits pushed to integration at https://github.com/mozilla/addon-sdk

https://github.com/mozilla/addon-sdk/commit/df72c4b7fcd02ad789beea86c09fd6178ba0a8ea
Bug 874070 - Fix selection tests and tab-browser lib to listen for load events on <browser> rather than <tab>

https://github.com/mozilla/addon-sdk/commit/928bee438f792cfe181fab353a003184e5d3f309
Merge pull request #1002 from gijsk/bug874070
You need to log in before you can comment on or make changes to this bug.