874103 - Rename StringWrapper to avoid aliasing another struct for the static rooting analysis

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Steve Fink [:sfink] [:s:]]

From bz:


I'm looking at the browser rooting stuff, and there are 4 hazards in storage/test/test_StatementCache.cpp  that look like this:

Function 'void test_GetCachedStatement() [with StringType = StringWrapper]' has unrooted 'sql' of type 'StringWrapper' live across GC call mozIStorageBaseStatement.GetState at storage/test/test_StatementCache.cpp:66

But 'StringWrapper' has nothing to do with JS GC, or with JS at all.  It looks like this:

  class StringWrapper : public nsCString
  {
  public:
    StringWrapper(const char* aOther)
    {
      this->Assign(aOther);
    }
  };

so I'm not sure why the rooting analysis cares about it at all.

Comment 1

[Steve Fink [:sfink] [:s:]]

Attachment: Rename StringWrapper to avoid aliasing another struct for the static rooting analysis

Comment 2

[Terrence Cole [:terrence]]

Comment on attachment 751736 [details] [diff] [review]
Rename StringWrapper to avoid aliasing another struct for the static rooting analysis

Review of attachment 751736 [details] [diff] [review]:
-----------------------------------------------------------------

Silly, but r=me nonetheless.

Comment 3

[Steve Fink [:sfink] [:s:]]

http://hg.mozilla.org/integration/mozilla-inbound/rev/1d14e9de6418

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/1d14e9de6418