874140 - (Australis) The "Restore Defaults" button should have visibility:hidden instead of hidden="true"

Status: RESOLVED FIXED

(Firefox :: Toolbars and Customization, defect)

Description

[Jared Wein [:jaws] (please needinfo? me)]

See https://bugzilla.mozilla.org/show_bug.cgi?id=870869#c8 for more information.

Comment 1

[Mike Conley (:mconley) (:⚙️)]

D'oh, sorry about that. It's slightly unintuitive that element.hidden does not set visibility: hidden.

Comment 2

[Jared Wein [:jaws] (please needinfo? me)]

No problem, it's an easy mistake to make. I wish we had something similar to .collapsed but I don't think we do.

Comment 3

[Mike Conley (:mconley) (:⚙️)]

Attachment: Patch v1

Comment 4

[Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 755609 [details] [diff] [review]
Patch v1

Review of attachment 755609 [details] [diff] [review]:
-----------------------------------------------------------------

You can continue to use the .hidden setter and getter. All of the changes in CustomizeMode.jsm can be reverted.

::: browser/base/content/browser.css
@@ +663,5 @@
>    max-height: 0;
>  }
> +
> +#customization-reset-button[hidden="true"] {
> +  visibility: hidden;

display: -moz-box;

Comment 5

[Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 755609 [details] [diff] [review]
Patch v1

Review of attachment 755609 [details] [diff] [review]:
-----------------------------------------------------------------

This is fine to land once you make these changes and revert CustomizeMode.jsm.

::: browser/base/content/browser.css
@@ +663,5 @@
>    max-height: 0;
>  }
> +
> +#customization-reset-button[hidden="true"] {
> +  visibility: hidden;

To be clear, keep the visibility: hidden; and add the display: -moz-box;.

Comment 6

[Mike Conley (:mconley) (:⚙️)]

Attachment: Patch v1.1 (r+'d by jaws)

D'oh, yep - this is wayyy simpler. Thanks.

Comment 7

[Mike Conley (:mconley) (:⚙️)]

Landed on UX as https://hg.mozilla.org/projects/ux/rev/efe1213b8bb8

Comment 8

[:Gijs (he/him)]

Per https://firefox-ux.etherpad.mozilla.org/Australis-pretesting-UXreview , should we be disabling instead of hiding it after all? :-(

Comment 9

[:Gijs (he/him)]

https://hg.mozilla.org/mozilla-central/rev/efe1213b8bb8