Closed
Bug 874153
Opened 11 years ago
Closed 11 years ago
My projects page
Categories
(Webmaker Graveyard :: webmaker.org, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: kate, Assigned: thecount)
Details
Attachments
(1 file, 1 obsolete file)
No description provided.
|
Reporter | |
Updated•11 years ago
|
Assignee: nobody → kate
|
|
Reporter | |
Comment 1•11 years ago
|
||
Attachment #751768 -
Flags: review?(pomax)
Comment on attachment 751768 [details] [review] https://github.com/mozilla/webmaker.org/pull/22 comments in the pull request.
Attachment #751768 -
Flags: review?(ross)
Attachment #751768 -
Flags: review?(pomax)
Attachment #751768 -
Flags: review-
|
Assignee | |
Comment 3•11 years ago
|
||
Comment on attachment 751768 [details] [review] https://github.com/mozilla/webmaker.org/pull/22 Updates. Not all done yet, but I asked a few questions to your pull request comments. I have these fixed in here: https://github.com/mozilla/webmaker.org/pull/23
Attachment #751768 -
Flags: review- → review?(pomax)
|
|
Assignee | |
Updated•11 years ago
|
Assignee: kate → scott
|
|
Assignee | |
Comment 4•11 years ago
|
||
New pull request.
Attachment #751768 -
Attachment is obsolete: true
Attachment #751768 -
Flags: review?(ross)
Attachment #751768 -
Flags: review?(pomax)
Attachment #751819 -
Flags: review?(ross)
Attachment #751819 -
Flags: review?(pomax)
|
||
Comment 5•11 years ago
|
||
Comment on attachment 751819 [details] [review] https://github.com/mozilla/webmaker.org/pull/23 Thanks Scott - tis looking epic
Attachment #751819 -
Flags: review?(ross) → review+
Comment on attachment 751819 [details] [review] https://github.com/mozilla/webmaker.org/pull/23 R+ but we need a follow-up ticket to clean up this code. It's a mix of jQuery and pure JS atm, and we should either go all jQuery, or all pure (and since we can't avoid loading jQuery, my vote would be for proper jQuery code. That said, that's a dicussion for that follow-up bug).
Attachment #751819 -
Flags: review?(pomax) → review+
|
|
Assignee | |
Comment 7•11 years ago
|
||
Staged: https://github.com/mozilla/webmaker.org/commit/4a136cdbae9fa8f7aeae636853daa1f1a20fd5d2
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
|
|
Assignee | |
Comment 8•11 years ago
|
||
Here is the follow up bug 874242
|
||
Updated•11 years ago
|
Attachment mime type: text/plain text/plain → text/x-github-pull-request text/x-github-pull-request
You need to log in
before you can comment on or make changes to this bug.
Description
•