Closed
Bug 874242
Opened 11 years ago
Closed 11 years ago
pure js vs all jquery
Categories
(Webmaker Graveyard :: webmaker.org, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: thecount, Assigned: kate)
Details
Attachments
(1 file)
This is a follow up from bug 874153 A question that comes up a lot is the idea of mixing js and jquery. We should figure out where we stand on this. Should we have all js, mix in jquery where we need it, or go to all jquery.
Assignee | ||
Updated•11 years ago
|
Assignee: nobody → kate
Assignee | ||
Comment 1•11 years ago
|
||
Attachment #752927 -
Flags: review?(pomax)
Comment on attachment 752927 [details] [review] https://github.com/mozilla/webmaker.org/pull/24 a few nits, but if we can use that other URI library that's probably much better than using a fairly fragile 'replace' function.
Attachment #752927 -
Flags: review?(pomax) → review-
Comment on attachment 752927 [details] [review] https://github.com/mozilla/webmaker.org/pull/24 works great, land this sucker
Attachment #752927 -
Flags: review- → review+
Assignee | ||
Comment 4•11 years ago
|
||
commit bf19d57e09036eb57e9f1785e3495273e81080b0
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Updated•11 years ago
|
Attachment mime type: text/plain → text/x-github-pull-request
You need to log in
before you can comment on or make changes to this bug.
Description
•