publishing a featured make, then changing the name and publishing it again, causes two makes

RESOLVED FIXED

Status

defect
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: thecount, Assigned: thecount)

Tracking

Details

Attachments

(1 attachment)

Assignee

Description

6 years ago
You can see this, by doing these STRs:

1. create a featured make on thimble-node.mofostaging.net. Example: <meta content="featured" name="webmaker:tags">
2. publish it.
3. check webmaker.mofostaging.net, and ensure you see it in the gallery.
4. go back to thimble, and change the title, and publish.
5. go back to webmaker.org, and you should see both old and new projects.

Not sure exactly where this bug is caused, in thimble, the makeapi or webmaker.org, but figured I would start it here. Just a guess.
Assignee

Comment 1

6 years ago
Expected: One project displayed, and it should be with the most recent title.
Actual: Both new and old titled projects are there.
Assignee

Updated

6 years ago
Assignee: nobody → scott
Assignee

Comment 2

6 years ago
Brett, is this something on our radar?

Basically, changing a project's title causes a new make entry from thimble, instead of updating.
Flags: needinfo?(brett)
IMO, a shitty bug, but not a blocker.

Comment 5

6 years ago
Comment on attachment 763707 [details]
https://github.com/mozilla/thimble.webmaker.org/pull/138/files

some comments in the pull request.
Attachment #763707 - Flags: review?(pomax) → review-
Assignee

Comment 6

6 years ago
Just some general questions in the pull request to your comments.

I agree with the general issue, but I'm thinking we need another solution.
Flags: needinfo?(pomax)
Assignee

Updated

6 years ago
Flags: needinfo?(pomax)
Flags: needinfo?(brett)
I'd love to save the makeid within Thimble because it's easier to do anything related to the makeapi, but this seems sane.

Comment 9

6 years ago
saving the makeid in Thimble means we're linking to independent databases. That is a bad plan.

Comment 10

6 years ago
two. TWO. I NEED AN EDIT BUTTON

Comment 11

6 years ago
Comment on attachment 763707 [details]
https://github.com/mozilla/thimble.webmaker.org/pull/138/files

I'm okay with this, if you massage the comment so it's only two lines (a full stop doesn't need to end the line). If we come up against a case where we need oldURL somewhere else, we can move it to its own middleware function.
Attachment #763707 - Flags: review?(pomax) → review+
Assignee

Comment 12

6 years ago
Staged: https://github.com/mozilla/thimble.webmaker.org/commit/0e718cec3191dd0f583fa9e54ac939656ad73cca
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.