874296 - publishing a featured make, then changing the name and publishing it again, causes two makes

Status: RESOLVED FIXED

(Webmaker Graveyard :: MakeAPI, defect)

Description

[Scott [:thecount] Downe]

You can see this, by doing these STRs:

1. create a featured make on thimble-node.mofostaging.net. Example: <meta content="featured" name="webmaker:tags">
2. publish it.
3. check webmaker.mofostaging.net, and ensure you see it in the gallery.
4. go back to thimble, and change the title, and publish.
5. go back to webmaker.org, and you should see both old and new projects.

Not sure exactly where this bug is caused, in thimble, the makeapi or webmaker.org, but figured I would start it here. Just a guess.

Comment 1

[Scott [:thecount] Downe]

Expected: One project displayed, and it should be with the most recent title.
Actual: Both new and old titled projects are there.

Comment 2

[Scott [:thecount] Downe]

Brett, is this something on our radar?

Basically, changing a project's title causes a new make entry from thimble, instead of updating.

Comment 3

[Mike Beltzner [:beltzner, not reading bugmail]]

IMO, a shitty bug, but not a blocker.

Comment 4

[Scott [:thecount] Downe]

Attachment: https://github.com/mozilla/thimble.webmaker.org/pull/138/files

Comment 5

[Pomax]

Comment on attachment 763707 [details]
https://github.com/mozilla/thimble.webmaker.org/pull/138/files

some comments in the pull request.

Comment 6

[Scott [:thecount] Downe]

Just some general questions in the pull request to your comments.

I agree with the general issue, but I'm thinking we need another solution.

Comment 7

[Scott [:thecount] Downe]

Comment on attachment 763707 [details]
https://github.com/mozilla/thimble.webmaker.org/pull/138/files

Thoughts?

Comment 8

[Jon Buckley [:jbuck]]

I'd love to save the makeid within Thimble because it's easier to do anything related to the makeapi, but this seems sane.

Comment 9

[Pomax]

saving the makeid in Thimble means we're linking to independent databases. That is a bad plan.

Comment 10

[Pomax]

two. TWO. I NEED AN EDIT BUTTON

Comment 11

[Pomax]

Comment on attachment 763707 [details]
https://github.com/mozilla/thimble.webmaker.org/pull/138/files

I'm okay with this, if you massage the comment so it's only two lines (a full stop doesn't need to end the line). If we come up against a case where we need oldURL somewhere else, we can move it to its own middleware function.

Comment 12

[Scott [:thecount] Downe]

Staged: https://github.com/mozilla/thimble.webmaker.org/commit/0e718cec3191dd0f583fa9e54ac939656ad73cca