874308 - [Buri][GCF][STK]case 27.22.4.9.2/1 (SELECT ITEM, next action indicator, successful) failed

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Settings, defect, P1)

Description

[sync-1]

AU_LINUX_GECKO_ICS_STRAWBERRY_V1.01.00.01.019.105
 Firefox os  v1.0.1
 Mozilla build ID:20130512070209
 
 
 
 +++ This bug was initially created as a clone of Bug #455580 +++
 
 DEFECT DESCRIPTION:
 [GCF][STK]case 27.22.4.9.2/1 (SELECT ITEM, next action indicator, successful) failed
 
  REPRODUCING PROCEDURES:
 
 1 run GCF case 27.22.4.9.2/1 (SELECT ITEM, next action indicator, successful) ;
 2 at step4, can not display next action indicator at select item command--->KO
 
 
 similar bug 407666 
 
  EXPECTED BEHAVIOUR:
 as spec 51.010-4 ,The Terminal may indicate to the user the consequences of performing the selection of an item.
 
  ASSOCIATE SPECIFICATION:
 
  TEST PLAN REFERENCE:
 
  TOOLS AND PLATFORMS USED:
 
  USER IMPACT:
 
  REPRODUCING RATE:
 
  For FT PR, Please list reference mobile's behavior:
 
 ++++++++++ end of initial bug #455580 description ++++++++++
 
 
 
 CONTACT INFO (Name,Phone number):
 
  DEFECT DESCRIPTION:
 
  REPRODUCING PROCEDURES:
 
  EXPECTED BEHAVIOUR:
 
  ASSOCIATE SPECIFICATION:
 
  TEST PLAN REFERENCE:
 
  TOOLS AND PLATFORMS USED:
 
  USER IMPACT:
 
  REPRODUCING RATE:
 
  For FT PR, Please list reference mobile's behavior:

Comment 1

[sync-1]

Clone from brother

Comment 2

[sync-1]

Attachment: snapshot

Clone from brother

Comment 3

[buri.blff]

This bug is GCF block;

Comment 4

[Joe Cheng [:jcheng] (please needinfo)]

frsela, do you need logs for this one too? Thanks

Comment 5

[Carol Yang [:cyang]]

This looks a lot like: https://bugzilla.mozilla.org/show_bug.cgi?id=847034#c5

Specifically, comment 5 for bug 847034 mentioned that this is not blocking. Can someone please confirm?

Comment 6

[Fernando R. Sela (no CC, needinfo please) [:frsela]]

Trying to understand this better.

with "can not display next action indicator at select item command" you mean the backward arrow in the top-left corner?

Comment 7

[buri.blff]

Attachment: The right screen short of other devices

we should give indicator as the image

Comment 8

[buri.blff]

And we need to consider there will be several language.

Comment 9

[buri.blff]

This is GCF block.

Comment 10

[Carol Yang [:cyang]]

FYI, the default Android code does not support 'Next Action Indicator'.

Daniel, thoughts on this being a blocker?

Comment 11

[Fernando R. Sela (no CC, needinfo please) [:frsela]]

(In reply to buri.blff from comment #7)
> Created attachment 752575 [details]
> The right screen short of other devices
> 
> we should give indicator as the image

Ok, you mean the little text ... :p
In which field of the received JSON is it stored? can you provide logs with gaia debug level enabled to check if the platform is sending this data?

Thanks

Comment 12

[Carol Yang [:cyang]]

(In reply to Fernando R. Sela [:frsela] from comment #11)
> (In reply to buri.blff from comment #7)
> > Created attachment 752575 [details]
> > The right screen short of other devices
> > 
> > we should give indicator as the image
> 
> Ok, you mean the little text ... :p
> In which field of the received JSON is it stored? can you provide logs with
> gaia debug level enabled to check if the platform is sending this data?

Commercial RIL does not send this info up (note that as mentioned in Comment 10, Android does not support this either). To support this, it would require change from both Commercial RIL and Gaia.

> 
> Thanks

Comment 13

[Daniel Coloma:dcoloma]

Clearly not something we can do in 1.0.1 timeframe. Carol, is this functionality added for 1.1 Commercial Ril?

Comment 14

[Carol Yang [:cyang]]

(In reply to Daniel Coloma:dcoloma from comment #13)
> Clearly not something we can do in 1.0.1 timeframe. Carol, is this
> functionality added for 1.1 Commercial Ril?

We can add this to 1.1 Commericial RIL but would also need Gaia support for this to be complete though.

Comment 15

[buri.blff]

This is GCF block case. Can we only resolve it in v1.1 in the future??

Comment 16

[buri.blff]

(In reply to Fernando R. Sela [:frsela] from comment #11)
> (In reply to buri.blff from comment #7)
> > Created attachment 752575 [details]
> > The right screen short of other devices
> > 
> > we should give indicator as the image
> 
> Ok, you mean the little text ... :p
> In which field of the received JSON is it stored? can you provide logs with
> gaia debug level enabled to check if the platform is sending this data?
> 
> Thanks

yes, as the The right screen short of other devices show, there is an little text such as "send sms" in Item1 to tell user what's the function of the item1.

Comment 17

[buri.blff]

mozilla please update pr status. thanks.

Comment 18

[buri.blff]

the qcom case id:01202376

Comment 19

[Carol Yang [:cyang]]

Fernando, can you please let me know the JSON you expect for the 'Next Action Indicator'?

Comment 20

[buri.blff]

this is block certification, please update status. thanks.

Comment 21

[Fernando R. Sela (no CC, needinfo please) [:frsela]]

(In reply to Carol Yang from comment #19)
> Fernando, can you please let me know the JSON you expect for the 'Next
> Action Indicator'?

I don't have any special preference :)

For example "nai" :p

Comment 22

[Carol Yang [:cyang]]

Ok, so something Commercial RIL will send something like this up:

RILContentHelper: Received message 'RIL:StkCommand': {"commandNumber":1,"typeOfCommand":37,"commandQualifier":0,"options":{"title":"SIM Toolkit","items":[{"identifier":128,"text":"Item 1","nai":"Send sms"},{"identifier":129,"text":"Item 2","nai":"Set Up Call"},{"identifier":130,"text":"Item 3","nai":"Provide Local Information"}],"presentationType":0}}

Comment 23

[Fernando R. Sela (no CC, needinfo please) [:frsela]]

Attachment: Adding STK next action indicator support

Comment 24

[Nivi]

Hi Fernando, 
Do you expect an empty string (nai: '') if there is no Next Action Indicator tag or just no nai tag at all in the message?

Comment 25

[Fernando R. Sela (no CC, needinfo please) [:frsela]]

(In reply to Nivi from comment #24)
> Hi Fernando, 
> Do you expect an empty string (nai: '') if there is no Next Action Indicator
> tag or just no nai tag at all in the message?

Both are Ok

Comment 26

[Nivi]

Cool. Am sending empty string for now. :)
Thanks.

Comment 27

[Nivi]

ferjm -

We need to send some key strings to Gaia for displaying the Next Action Indicator on the Set up menu. Here's a list of them and the default English strings.

stkItemsNaiSetUpCall- Set Up Call
stkItemsNaiSendSs - Send SS
stkItemsNaiSendUssd - Send USSD
stkItemsNaiSendSms - Send SMS
stkItemsNaiSendDtmf - Send DTMF
stkItemsNaiLaunchBrowser - Launch Browser
stkItemsNaiPlayTone - Play Tone
stkItemsNaiDisplayText - Display Text
stkItemsNaiGetInkey - Get Inkey
stkItemsNaiGetInput - Get Input
stkItemsNaiSelectItem - Select Item
stkItemsNaiSetUpMenu - Set Up Menu
stkItemsNaiProvideLocalInfo - Provide Local Info
stkItemsNaiSetIdleModeText - Set Idle Mode Text
stkItemsNaiOpenChannel - Open Channel
stkItemsNaiCloseChannel - Close Channel
stkItemsNaiReceiveData - Receive Data
stkItemsNaiSendData - Send Data
stkItemsNaiGetChannelStatus - Get Channel Status

Can you add these too along with the Mmi codes [bugzilla 879032]?

Nivi.

Comment 28

[Nivi]

Hi Fernando (frsela),

I grabbed your gaia patch for displaying nai and tested with it. I don't see the nai string being displayed on the Toolkit menu. I am sending you this string - {commandNumber : 1,                         typeOfCommand : 37,                         commandQualifier : 0, options : {title : 'Toolkit Menu', items:[{identifier : 1,text : 'Item 1',nai : 'stkItemsNaiSendSms'},{identifier : 2,text : 'Item 2',nai : 'stkItemsNaiSetUpCall'},{identifier : 3,text : 'Item 3',nai : 'stkItemsNaiLaunchBrowser'},{identifier : 4,text : 'Item 4',nai : 'stkItemsNaiProvideLocalInfo'}], presentationType : 0}}

Can you please test with this?

Comment 29

[Nivi]

Hi Fernando (frsela),

You need this patch as well in addition to yours -

diff --git a/apps/settings/js/icc.js b/apps/settings/js/icc.js
index 458acfd..a4f6f75 100644
--- a/apps/settings/js/icc.js
+++ b/apps/settings/js/icc.js
@@ -487,6 +487,7 @@
         iccStkList.appendChild(buildMenuEntry({
           id: 'stk-menuitem-' + menuItem.identifier,
           text: menuItem.text,
+          nai: menuItem.nai,
           onclick: onMainMenuItemClick,
           attributes: [['stk-menu-item-identifier', menuItem.identifier]]
         }));

With this change, I can see the Nai string on the menu.

Nivi.

Comment 30

[Fernando R. Sela (no CC, needinfo please) [:frsela]]

(In reply to Nivi from comment #29)
> Hi Fernando (frsela),
> 
> You need this patch as well in addition to yours -
> 
> diff --git a/apps/settings/js/icc.js b/apps/settings/js/icc.js
> index 458acfd..a4f6f75 100644
> --- a/apps/settings/js/icc.js
> +++ b/apps/settings/js/icc.js
> @@ -487,6 +487,7 @@
>          iccStkList.appendChild(buildMenuEntry({
>            id: 'stk-menuitem-' + menuItem.identifier,
>            text: menuItem.text,
> +          nai: menuItem.nai,
>            onclick: onMainMenuItemClick,
>            attributes: [['stk-menu-item-identifier', menuItem.identifier]]
>          }));
> 
> With this change, I can see the Nai string on the menu.
> 
> Nivi.

Oh, yeah ! I supposed NAI was only for "SELECT_ITEM" menues and not for the main one.

Thanks ! I'll fix it now.

Comment 31

[Fernando R. Sela (no CC, needinfo please) [:frsela]]

Fixed. One question: Help menus should support NAI too?

Comment 32

[Fernando Jiménez Moreno [:ferjm]]

(In reply to Nivi from comment #27)
> ferjm -
> 
> We need to send some key strings to Gaia for displaying the Next Action
> Indicator on the Set up menu. Here's a list of them and the default English
> strings.
> 
> stkItemsNaiSetUpCall- Set Up Call
> stkItemsNaiSendSs - Send SS
> stkItemsNaiSendUssd - Send USSD
> stkItemsNaiSendSms - Send SMS
> stkItemsNaiSendDtmf - Send DTMF
> stkItemsNaiLaunchBrowser - Launch Browser
> stkItemsNaiPlayTone - Play Tone
> stkItemsNaiDisplayText - Display Text
> stkItemsNaiGetInkey - Get Inkey
> stkItemsNaiGetInput - Get Input
> stkItemsNaiSelectItem - Select Item
> stkItemsNaiSetUpMenu - Set Up Menu
> stkItemsNaiProvideLocalInfo - Provide Local Info
> stkItemsNaiSetIdleModeText - Set Idle Mode Text
> stkItemsNaiOpenChannel - Open Channel
> stkItemsNaiCloseChannel - Close Channel
> stkItemsNaiReceiveData - Receive Data
> stkItemsNaiSendData - Send Data
> stkItemsNaiGetChannelStatus - Get Channel Status
> 
> Can you add these too along with the Mmi codes [bugzilla 879032]?
> 
> Nivi.

Sure. I'll add them to bug 879032.

Comment 33

[Fernando Jiménez Moreno [:ferjm]]

Actually, can just these strings be added along with the Gaia patch for this bug? It looks like the strings need to be added to the settings app, not the dialer one as in bug 879032.

Comment 34

[Fernando R. Sela (no CC, needinfo please) [:frsela]]

Attachment: Nai localized strings

Comment 35

[Fernando R. Sela (no CC, needinfo please) [:frsela]]

Comment on attachment 761339 [details]
Adding STK next action indicator support

Rebased and with localized strings.

Comment 36

[Noemí Freire (:noemi)]

Hi Fabien,

Could you please help us with the review?. Thanks!

Comment 37

[Fabien Cazenave [:kaze]]

Comment on attachment 761339 [details]
Adding STK next action indicator support

Looks OK to me. Note that it would be better to use the localize() helper rather than doing “.textContent = _(id)”.

Comment 38

[Fernando R. Sela (no CC, needinfo please) [:frsela]]

Kaze, thanks for the suggestion. I'll fix the nit asap, but landing since it's needed in leo.

Landed: https://github.com/mozilla-b2g/gaia/commit/895b29720949517187f0e8451fa205c6c4b5b232

Comment 39

[Noemí Freire (:noemi)]

Hi John,

Could you please help us on uplifting this patch to V1-train?, we need to unblock STK/ICC testing on V1-train. Thanks!

Comment 40

[Gareth Aye [:gaye] (back from PTO)]

Uplifted 895b29720949517187f0e8451fa205c6c4b5b232 to:
v1-train: ec6d94cc150d4ebc44fab47faaa856364b8f83cf

Comment 41

[John Ford [:jhford] CET/CEST Berlin Time]

v1.1.0hd: ec6d94cc150d4ebc44fab47faaa856364b8f83cf