874368 - [system] closing/removing/dismissing notifications by swiping right to left only works if starting very left

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::System, defect, P2)

Description

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Boot2Gecko 1.1.0.0-prerelease 20130520230207 on Unagi

Removing notifications by swiping right to left only works if the swipe starts on the very left.

Steps to reproduce:
1. Open the notifications menu.
2. Press Power and Home for a screenshot and its notification.
3. Start dragging to the left, starting from the position where the timestamp is ("now").
Actual result:
Notification not dismissed.
4. Start dragging to the left, starting from the center.
Actual result:
Notification not dismissed.
5. Start dragging to the left, starting left from the text.
Actual result:
Notification gets dismissed.

Left to right swiping works as expected.

Comment 1

[Staś Małolepszy :stas]

This has potential implications for our RTL support.

Comment 2

[Stephany Wilkes]

Jacqueline, I'm going through RTL bugs in conjunction with Arabic and patterns we updated during the Toronto work week. Can I resolve this as invalid based on new Notifications design since the bug was created, or no?

Comment 3

[Jacqueline Savory [:jsavory] UX]

Passing to Rob as he has been working on notifications.

Comment 4

[Rob MacDonald [:robmac]]

This to me is a valid bug. Notifications should be able to be dismissed regardless of the swipe direction.

Comment 5

[Jason Smith [:jsmith]]

This is something we should fix, but I don't think we would hold a release on this for 2.0, since this is a long-standing bug.

Comment 6

[Jason Smith [:jsmith]]

Product - When are we planning to support RTL locales (i.e. what release)?

Comment 7

[Stephany Wilkes]

Since I'm doing L10N PM, we are aiming for 2.1 but that will be late. We'd at least like to get some basic RTL support in and done for partners to cherry pick, but it was not high priority as we didn't even know until post-2.0 that Arabic was coming. Let me know if you'd like to schedule some time to talk through the roadmap.

Comment 8

[Stephany Wilkes]

Assigning to Pavel. Pavel, let me know if you can take this and if not I'll reassign. Thanks!

Comment 9

[Pavel Ivanov [:ivanovpavel][:pivanov] UX]

Hey Stephany,

sorry for the delay. I think this is complicated to me. Maybe is a good idea to assign this to someone else.

Comment 10

[Stephany Wilkes]

Reproduces on Flame 2.1 - 2014-09-08.

Comment 11

[Dylan Oliver [:doliver]]

RTL triage: P2 -- will make a best effort to get this into the 2.2 release.

Comment 12

[Dylan Oliver [:doliver]]

RTL update: marking required bugs as feature-b2g:2.2+ (and removing blocking flags)

Comment 13

[Etienne Segonzac (:etienne)]

I think the logic is good but the performance are so bad that it looks like it's not working.
Patch incoming :)

Comment 14

[GitHub Autolander Bot]

Attachment: [PullReq] etiennesegonzac:bug-874368 to mozilla-b2g:master

Comment 15

[Etienne Segonzac (:etienne)]

Comment on attachment 8557862 [details] [review]
[PullReq] etiennesegonzac:bug-874368 to mozilla-b2g:master

Hey Chris, what do you think?
(Trying to keep this patch small since it's 2.2+.)

Won't be easy to test so I'm requesting feedback before tackling the unit tests.

Comment 16

[Chris Lord [:cwiiis]]

Comment on attachment 8557862 [details] [review]
[PullReq] etiennesegonzac:bug-874368 to mozilla-b2g:master

Looks good - bonus points if you used your inertia calculation to alter the trasition duration :)

Comment 17

[Etienne Segonzac (:etienne)]

Comment on attachment 8557862 [details] [review]
[PullReq] etiennesegonzac:bug-874368 to mozilla-b2g:master

The notifications tests weren't in a very good shape :/
The unit ones weren't even running on my machine at first... but did my best!

Comment 18

[Chris Lord [:cwiiis]]

Comment on attachment 8557862 [details] [review]
[PullReq] etiennesegonzac:bug-874368 to mozilla-b2g:master

Looks good, but I think I have enough comments that I'd like to see another run before granting r+.

Comment 19

[Etienne Segonzac (:etienne)]

Comment on attachment 8557862 [details] [review]
[PullReq] etiennesegonzac:bug-874368 to mozilla-b2g:master

updated!

Comment 20

[Chris Lord [:cwiiis]]

Comment on attachment 8557862 [details] [review]
[PullReq] etiennesegonzac:bug-874368 to mozilla-b2g:master

Couple of nits, looks good :)

Comment 21

[GitHub Autolander Bot]

Pull request has landed in master: https://github.com/mozilla-b2g/gaia/commit/c7c6315de853290a485e85e16310932f5b80c402

Comment 22

[Derek Harris [:DerekH] - Dont need info. Last day 6/5/15]

This issue is verified fixed on Flame 3.0 and Flame 2.2

If the user swipes a notification left or right starting from anywhere on the notification, it will be dismissed as expected.

Environmental Variables:
Device: Flame 3.0 (319mb)(Kitkat)(Full Flash)
Build ID: 20150205010209
Gaia: 2b83a6d5d1185a438b5bbd287497ac2743b501db
Gecko: 34a66aaaca81
Gonk: e7c90613521145db090dd24147afd5ceb5703190
Version: 38.0a1 (3.0)
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:38.0) Gecko/38.0 Firefox/38.0


Environmental Variables:
Device: Flame 2.2 (319mb)(Kitkat)(Full Flash)
Build ID: 20150205002503
Gaia: c2047a46e29696238e9b4c9caaba47736421449a
Gecko: adfba0a07e9b
Gonk: e7c90613521145db090dd24147afd5ceb5703190
Version: 37.0a2 (2.2)
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:37.0) Gecko/37.0 Firefox/37.0