FHR payload population errors cause invalid data to be submitted

RESOLVED WORKSFORME

Status

Firefox Health Report
Client: Desktop
RESOLVED WORKSFORME
5 years ago
2 years ago

People

(Reporter: mreid, Unassigned)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

5 years ago
Created attachment 752178 [details]
FHR Payload with invalid structure

We received a submission with 4 errors like this:
Error populating data for day: org.mozilla.appInfo.versions: invalid 'in' operand outputDataDays[(intermediate value)] JS Stack trace: @HealthReport.jsm:4567 < TaskImpl_run@Task.jsm:192 < effort@promise.js:55 < resolved@promise.js:117 < then@promise.js:37 < resolve@promise.js:143 < onSuccess@HealthReport.jsm:3165 < effort@promise.js:55 < resolved@promise.js:117 < then@promise.js:37 < resolve@promise.js:143 < onSuccess@HealthReport.jsm:3091 < effort@promise.js:55 < resolved@promise.js:117 < then@promise.js:37 < resolve@promise.js:143 < TaskImpl_run@Task.jsm:220 < effort@promise.js:55 < resolved@promise.js:117 < then@promise.js:37 < resolve@promise.js:143 < onComplete@HealthReport.jsm:3811 < effort@promise.js:55 < resolved@promise.js:117 < then@promise.js:37 < resolve@promise.js:143 < onResult@Sqlite.jsm:494 < effort@promise.js:55 < resolved@promise.js:117 < then@promise.js:37 < resolve@promise.js:143 < @Sqlite.jsm:772

The payload contains an invalid structure in that certain values we expect to be JSON objects were scalar values instead.  Examples are a couple of keys inside 'data.days' which are numbers:
 "2013-05-16": -8.987947398262031e+307
 "2013-05-17": -8.987947396711135e+307

And the top-level 'geckoAppInfo':
 "geckoAppInfo": -8.987947396707351e+307

This may be a one-off problem, I ran a job to look for 'data.days' keys with non-object values and this is the only one at the moment.

Comment 1

5 years ago
Wat.
Is someone not checking the output of malloc somewhere deep in the bowels of Gecko? Cosmic rays? Database corruption?

That's looking like a mostly-1s 8-byte block interpreted as a float...
FHR is going away per bug 1209088, closing.
Status: NEW → RESOLVED
Last Resolved: 2 years ago
Resolution: --- → WORKSFORME
You need to log in before you can comment on or make changes to this bug.