Closed Bug 874459 Opened 9 years ago Closed 9 years ago

Set a valid window icon for desktop on Mac

Categories

(Firefox OS Graveyard :: General, defect)

x86_64
Windows 7
defect
Not set
normal

Tracking

(blocking-b2g:leo+, firefox22 wontfix, firefox23 wontfix, firefox24 fixed, b2g18 fixed, b2g18-v1.0.0 wontfix, b2g18-v1.0.1 wontfix, b2g-v1.1hd fixed)

RESOLVED FIXED
1.1 QE3 (26jun)
blocking-b2g leo+
Tracking Status
firefox22 --- wontfix
firefox23 --- wontfix
firefox24 --- fixed
b2g18 --- fixed
b2g18-v1.0.0 --- wontfix
b2g18-v1.0.1 --- wontfix
b2g-v1.1hd --- fixed

People

(Reporter: ochameau, Assigned: ochameau)

Details

(Whiteboard: [NPOTB])

Attachments

(2 files, 1 obsolete file)

Bug 865210 didn't fixed the icon on Mac.
We should also have a valid icon on b2g desktop app on this OS.
Comment on attachment 752200 [details] [diff] [review]
Set a valid window icon for desktop on Mac

Myk, I tried to mimic what is being done for Firefox but haven't tested this patch. Could you give it a try?
Attachment #752200 - Flags: feedback?(myk)
The build succeeds after I correct the path to which the image file is copied:

    cp -RL $(srcdir)/b2g.icns $(DIST)/$(APP_NAME).app/Contents/Resources/$(MOZ_APP_NAME).icns

But Mac OS still doesn't display the icon in the dock, the Alt-Tab list, and the Finder.

Perhaps the only icon in the file is too small?  The Firefox ICNS files contain multiple sizes, including some large ones; and if I copy one of those to b2g.icns, then the icon does appear.
I did some research, and I can't find good info on icon requirements in Apple's docs <http://developer.apple.com/library/mac/navigation/>, but Wikipedia has some useful info <http://en.wikipedia.org/wiki/Apple_Icon_Image_format>, as does this Stack Overflow question <http://stackoverflow.com/questions/6337787/how-can-i-set-the-icon-for-a-mac-application-in-xcode>.
Attached image b2g.icns
I used imagemagick to create this icns file, but it looks like it can't work:
  http://leonid.shevtsov.me/en/how-to-create-icns-icons-for-os-x
I attached a new version converted via this online service that is using libicns:
  http://iconverticons.com/online/
Comment on attachment 752200 [details] [diff] [review]
Set a valid window icon for desktop on Mac

The new image works!  So this seems great with the new image and the corrected path.
Attachment #752200 - Flags: feedback?(myk) → feedback+
Attachment #752200 - Attachment is obsolete: true
Comment on attachment 754424 [details] [diff] [review]
Set a valid window icon for desktop on Mac

New patch with MacOS-compatible icns file and corrected icon path.
Attachment #754424 - Flags: review?(21)
Comment on attachment 754424 [details] [diff] [review]
Set a valid window icon for desktop on Mac

I'm confident in Myk here.
Attachment #754424 - Flags: review?(21) → review?(myk)
Comment on attachment 754424 [details] [diff] [review]
Set a valid window icon for desktop on Mac

(Aside: for some reason this and the earlier patches fail to apply to my Git clone of the Git mirror of mozilla-central.  But they do apply to my Hg clone of inbound, and a diff generated from that clone then applies to the Git clone.)
Attachment #754424 - Flags: review?(myk) → review+
https://hg.mozilla.org/mozilla-central/rev/ccff1558f51b
Assignee: nobody → poirot.alex
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Comment on attachment 754424 [details] [diff] [review]
Set a valid window icon for desktop on Mac

[Approval Request Comment]
Bug caused by (feature/regressing bug #): No regression; this never worked.
User impact if declined: The impact is minor, but both B2G Desktop and the Firefox OS Simulator would continue to lack customized dock and app icons on Mac if this request were to be denied, which is unexpected and seems off to users.
Testing completed: In addition to local machine testing, this has been baking on mozilla-central for a week and a half.
Risk to taking this patch (and alternatives if risky): The risk is low (no changes on Gonk), and there are no alternatives.
String or UUID changes made by this patch: None.
Attachment #754424 - Flags: approval-mozilla-b2g18?
leo+, but only because this is NPOTB. We're past the point of approvals.
blocking-b2g: --- → leo+
Whiteboard: [NPOTB]
Attachment #754424 - Flags: approval-mozilla-b2g18?
https://hg.mozilla.org/releases/mozilla-b2g18/rev/bcf12de92882


(In reply to Alex Keybl [:akeybl] from comment #14)
> leo+, but only because this is NPOTB. We're past the point of approvals.

Thanks, Alex, I'll treat desktop-specific changes as NPOTB from now on and request leo+ approval on that basis.

But note that <https://wiki.mozilla.org/Release_Management/B2G_Landing> still directs me to "nominate for… approval-mozilla-b2g18" for "all other landings for v1.x".
Flags: in-moztrap-
You need to log in before you can comment on or make changes to this bug.