87451 - Self-signed certificate dialog disappears on "<Alt>" keypress

Status: VERIFIED FIXED

(Core Graveyard :: Security: UI, defect, P2)

Description

[pocemit]

Go to the URL in summary, and wait for the certificate dialog to appear. Then
press <Alt> key, which will make the dialog go away.
Pressing it again will cancel the connection to the site.
Seeing this in 20010623 build.

Comment 1

[pocemit]

Oops, switching product.

Comment 2

[pocemit]

Oops, wrong product.

Comment 3

[pocemit]

Looks like the problem is a typo in
mozilla/security/manager/pki/resources/content/newserver.xul:

Index: security/manager/pki/resources/content/newserver.xul
===================================================================
RCS file: /cvsroot/mozilla/security/manager/pki/resources/content/newserver.xul,v
retrieving revision 1.9
diff -u -r1.9 newserver.xul
--- security/manager/pki/resources/content/newserver.xul        2001/06/22
02:41:05     1.9
+++ security/manager/pki/resources/content/newserver.xul        2001/06/23 20:22:34
@@ -42,7 +42,7 @@
 <keyset id="keys">
   <key id="enter-key"  keycode="VK_ENTER"  oncommand="doOK()"    />
   <key id="return-key" keycode="VK_RETURN" oncommand="doOK()"    />
-  <key id="esc-key"    keycoce="VK_ESCAPE" oncommand="doCancel()"/>
+  <key id="esc-key"    keycode="VK_ESCAPE" oncommand="doCancel()"/>
 </keyset>
 
 <box orient="vertical" style="margin: 5px;" flex="1">

Changing this fixes it.

Comment 4

[pocemit]

adding keywords... 

Comment 5

[Stephen Walker]

cc'ing some psm people for review

Comment 6

[Mark Anderson]

It's not just newserver.xul.  It also occurs in 
mozilla/security/manager/pki/resources/content/domainMismatch.xul and 
mozilla/security/manager/pki/resources/content/serverCertExpired.xul.

I'd provide the patches myself, but my tree is somewhat different from a bunch 
of XUL changes that are getting carpooled in on Tuesday.

Reassigning to javi per Stephen Walker's comment on IRC and changing OS to ALL.

Comment 7

[pocemit]

I had someone test this on win32 and the dialog didn't go away, probably because
Win32 doesnt generate a keydown event for modifiers (does it?) The fix was
obviously because of a typo, how exactly are the other .xul files related?
(Other than the fact they dont have keyboard shortcuts?)...

Comment 8

[pocemit]

Oh never mind I didn't see all the other files being checked in just a few hours
ago.

Comment 9

[Bob Lord]

Target -> 2.1 unless javi thinks he can get it approved for 2.0.

Comment 10

[Stephen Walker]

javi fixed the typos. marking fixed.

Comment 11

[ckritzer (gone)]

to junruh

Comment 12

[John Unruh]

Verified.