Self-signed certificate dialog disappears on "<Alt>" keypress

VERIFIED FIXED in psm2.1

Status

Core Graveyard
Security: UI
P2
normal
VERIFIED FIXED
17 years ago
a year ago

People

(Reporter: pocemit, Assigned: Javier Delgadillo)

Tracking

Other Branch
psm2.1
x86
All

Firefox Tracking Flags

(Not tracked)

Details

(URL)

(Reporter)

Description

17 years ago
Go to the URL in summary, and wait for the certificate dialog to appear. Then
press <Alt> key, which will make the dialog go away.
Pressing it again will cancel the connection to the site.
Seeing this in 20010623 build.
(Reporter)

Comment 1

17 years ago
Oops, switching product.
Component: Security: General → Client Library
Product: Browser → PSM
Version: other → unspecified
(Reporter)

Comment 2

17 years ago
Oops, wrong product.
(Reporter)

Comment 3

17 years ago
Looks like the problem is a typo in
mozilla/security/manager/pki/resources/content/newserver.xul:

Index: security/manager/pki/resources/content/newserver.xul
===================================================================
RCS file: /cvsroot/mozilla/security/manager/pki/resources/content/newserver.xul,v
retrieving revision 1.9
diff -u -r1.9 newserver.xul
--- security/manager/pki/resources/content/newserver.xul        2001/06/22
02:41:05     1.9
+++ security/manager/pki/resources/content/newserver.xul        2001/06/23 20:22:34
@@ -42,7 +42,7 @@
 <keyset id="keys">
   <key id="enter-key"  keycode="VK_ENTER"  oncommand="doOK()"    />
   <key id="return-key" keycode="VK_RETURN" oncommand="doOK()"    />
-  <key id="esc-key"    keycoce="VK_ESCAPE" oncommand="doCancel()"/>
+  <key id="esc-key"    keycode="VK_ESCAPE" oncommand="doCancel()"/>
 </keyset>
 
 <box orient="vertical" style="margin: 5px;" flex="1">

Changing this fixes it.
(Reporter)

Comment 4

17 years ago
adding keywords... 
Keywords: patch, review

Comment 5

17 years ago
cc'ing some psm people for review

Comment 6

17 years ago
It's not just newserver.xul.  It also occurs in 
mozilla/security/manager/pki/resources/content/domainMismatch.xul and 
mozilla/security/manager/pki/resources/content/serverCertExpired.xul.

I'd provide the patches myself, but my tree is somewhat different from a bunch 
of XUL changes that are getting carpooled in on Tuesday.

Reassigning to javi per Stephen Walker's comment on IRC and changing OS to ALL.
Assignee: mstoltz → javi
OS: Linux → All
(Reporter)

Comment 7

17 years ago
I had someone test this on win32 and the dialog didn't go away, probably because
Win32 doesnt generate a keydown event for modifiers (does it?) The fix was
obviously because of a typo, how exactly are the other .xul files related?
(Other than the fact they dont have keyboard shortcuts?)...
(Reporter)

Comment 8

17 years ago
Oh never mind I didn't see all the other files being checked in just a few hours
ago.

Comment 9

17 years ago
Target -> 2.1 unless javi thinks he can get it approved for 2.0.
Priority: -- → P2
Target Milestone: --- → 2.1

Comment 10

17 years ago
javi fixed the typos. marking fixed.
Status: NEW → RESOLVED
Last Resolved: 17 years ago
Resolution: --- → FIXED

Comment 11

17 years ago
to junruh
QA Contact: ckritzer → junruh

Comment 12

17 years ago
Verified.
Status: RESOLVED → VERIFIED

Updated

13 years ago
Component: Security: UI → Security: UI
Product: PSM → Core
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.