874514 - Make class="hidden" behave the same as hidden="true" for XUL elements

Status: RESOLVED WONTFIX

(Core :: XUL, defect, P2)

Description

[Benjamin Smedberg]

In working on the plugin doorhanger and I'd really like to be able to use class="hidden" instead of hidden="true" on some of the XUL elements. I have a patch which treats .hidden just like [hidden="true"].

Comment 1

[Benjamin Smedberg]

Attachment: Make class="hidden" work, rev. 11

Comment 2

[Benjamin Smedberg]

r?Neil since Enn is gone for a bit

Comment 3

[:Gavin Sharp [email: [e-mail]]]

(In reply to Benjamin Smedberg  [:bsmedberg] from comment #0)
> In working on the plugin doorhanger and I'd really like to be able to use
> class="hidden" instead of hidden="true" on some of the XUL elements.

Why?

Comment 4

[Benjamin Smedberg]

Mostly because I have a inbred hate for the hidden="true" selector, which is inefficient compared with class-matching selectors. Also because I was already using .classList.add for tweaking other classes on the same objects, and it became a lot more readable to use classes than mucking with the attributes.

Comment 5

[:Gavin Sharp [email: [e-mail]]]

Those don't seem like very strong arguments to me, and adding such a generic class name to xul.css seems likely to cause compatibility issues.

For XUL elements, you can set .hidden = true, instead of using setAttribute (http://hg.mozilla.org/mozilla-central/annotate/daf809df7936/content/xul/content/src/nsXULElement.cpp#l1410).

Comment 6

[Benjamin Smedberg]

Ah, I didn't know that, I thought it had to be in XBL. I'd love to eventually stop using the attribute, but for my scripting purposes I guess the .hidden property works ;-)

Comment 7

[[e-mail]]

Comment on attachment 752260 [details] [diff] [review]
Make class="hidden" work, rev. 11

[I was minded to cancel (if not deny) the review anyway, for much the same reason as has already been discussed.]