874519 - Strings in defer blocks are not getting localised

Status: VERIFIED FIXED

(Marketplace Graveyard :: Consumer Pages, defect)

Description

[Christopher Van Wiemeersch [:cvan]]

Notice that "Popular," "New," and "View All" are not localized in any language:
http://f.cl.ly/items/3m2e1C2k1Z313M2m3541/Screen%20Shot%202013-05-21%20at%2010.35.45%20AM.png

https://marketplace-dev.allizom.org/?lang=cs
https://marketplace-dev.allizom.org/?lang=fr
https://marketplace-dev.allizom.org/?lang=es
https://marketplace-dev.allizom.org/?lang=it
https://marketplace-dev.allizom.org/?lang=pl

I could be wrong, but anything immediately in the defer blocks doesn't look like it's getting picked up by L10n.js.

Comment 1

[Matt Basta [:basta]]

The strings haven't been translated yet:

https://github.com/mozilla/fireplace/blob/master/locale/it/LC_MESSAGES/messages.po

Those untranslated strings are post-redesign and the PO files haven't been updated (or translated) since before we landed the new designs.

Comment 2

[Matt Basta [:basta]]

Oooh, there actually is a bug in nunjucks that's preventing certain kinds of blocks from getting iterated over, though. Looking into it now.

Comment 3

[Matt Basta [:basta]]

https://github.com/mozilla/fireplace/commit/0d8f9965a947586434c71ebf902c1399e8405c32

CallExtensions were not fully iterating over their contents. This was causing, in some cases, certain blocks to get ignored during traversal.

Comment 4

[krupa raj[:krupa]]

I checked with ?lang=fr and most things were localized.