Closed Bug 874527 Opened 7 years ago Closed 6 years ago

Disable certain XUL crashtests under AddressSanitizer

Categories

(Testing :: Reftest, defect)

x86_64
Linux
defect
Not set

Tracking

(Not tracked)

RESOLVED WONTFIX

People

(Reporter: decoder, Assigned: decoder)

References

(Blocks 1 open bug)

Details

(Keywords: sec-want, Whiteboard: [asan][asan-test-failure])

Attachments

(1 file, 1 obsolete file)

There are still some unresolved failures in crashtests under ASan. Both issues are on file as bug 874486 and bug 787715, but until these are resolved (which is unlikely to happen quickly), we need to disable these tests under ASan so the whole testsuite runs and other errors are not covered by these failures.

The attached patch disables the necessary tests using the "skip-if(AddressSanitizer)" command which specifically only disables the tests when running under ASan. Crashtests on TBPL is green with these changes.

We can also leave this bug open to re-enable the tests when we have fixes. I don't know what the usual procedure is in this case, so I'm open for suggestions :)
Attached patch Patch (obsolete) — Splinter Review
Attachment #752263 - Flags: review?(dbaron)
Attached patch PatchSplinter Review
Bug 874486 has already been fixed, so we don't need to disable that test anymore :)
Attachment #752263 - Attachment is obsolete: true
Attachment #752263 - Flags: review?(dbaron)
Attachment #753330 - Flags: review?(dbaron)
Comment on attachment 753330 [details] [diff] [review]
Patch

r=dbaron if you put a bug number in a comment at the end of the line for each disabling (see, e.g., the comments shown in the patch context in the second file you're touching)

It's not clear to me that bug 787715 is appropriate for all three of these tests; it looks like that bug only mentions two of them.  If it really is all 3, then 257752-1-recursion.xul should probably be mentioned in bug 787715 as well; if not, then an appropriate bug should be filed for the reason 257752-1-recursion.xul is being disabled (or, if it was accidental, it should be removed from the diff).
Attachment #753330 - Flags: review?(dbaron) → review+
It looks like this doesn't need to be landed after all, so I'm going to close this.
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.