874535 - Localized homepage looks for news articles without fallback

Status: RESOLVED INVALID

(support.mozilla.org :: Code Quality, task)

Description

[Shuhao]

Localized homepages currently will look for news articles and it will fail without a proper database setup. This is a roadblock to new contributors.

Comment 1

[Will Kahn-Greene [:willkg] ET needinfo? me]

This should be fixable by adding some more code to the sampledata generation.

Comment 2

[Shuhao]

So instead of falling back to a system where the page won't load, we just generate sample data that's localized? Would this need to happen for every single locale?

Comment 3

[Ricky Rosario [:rrosario, :r1cky]]

Something is fishy here. If this was really a bug, a lot of our locales would be broken. For example, the 'ak' locale doesn't have almost anything localized and it works:
https://support.mozilla.org/ak/home

Comment 4

[Shuhao]

That's not the case. This is when you do _not_ have a database dump (only data from ./manage.py generatedata). I don't exactly know where the code for generatedata lives right now but it seems it doesn't generate localized news articles.

Production is not affected as the entire database (all localizations) is available.

Comment 5

[Ricky Rosario [:rrosario, :r1cky]]

Can you paste a stack trace? That'll help get us on the same page here.

The code for getting news looks right (it falls back to en-US then None):
https://github.com/mozilla/kitsune/blob/master/apps/landings/views.py#L32

Comment 6

[Shuhao]

Just generated a fresh database. Seems to be okay now.

Closed as invalid as I was having trouble setting up earlier, so I might have done something wrong. If anyone else find something.. please reopen.