87456 - download time out should automatically reconnect

Status: VERIFIED FIXED

(SeaMonkey :: Installer, defect)

Description

[Sean Su]

In the even of time outs during the download part of the installer, the 
installer should automatically reconnect at least once.  Which means that the 
subsequent time out, toss the user into the Paused state and show the warning 
dialog.

Also reduce the time it takes before the time out happens, since we're 
automatically reconnecting anyways.

This was requested by PDT.

Comment 1

[Sean Su]

Syd, let me know if you want me to file the same bug against the mac and linux 
installers.

Comment 2

[Sean Su]

the patch will be with bug 86959

Comment 3

[Syd Logan]

I'd go as far as saying we should start trying to do everything requested of 
us for all three platforms, and look for opportunities to factor the code for 
what we implement out into common source whenever possible, so that the three 
platforms share implementations.

Comment 4

[Scott MacGregor]

I got an sr request for this bug but I don't see a reviewer yet. Feel free to
ping me once it's been reviewed. Sounds like syd has some questions about it. 

Comment 5

[Sean Su]

yeah, syd just wanted to make sure that any new code we write, is written so 
that it could be utilized in the native mac and linux installers.  The patch for 
this fix (which is attached to bug 86595) is windows only, and there's not easy 
way to factor it out at this point.

Thanks for the rs= on bug 86595.

Comment 6

[Sean Su]

er, I meant that the patch for this bug is attached to bug 86959 (not bug 
86595).

Comment 7

[Asa Dotzler [:asa]]

pushing out. 0.9.2 is done. (querying for this string will get you the list of
the 0.9.2 bugs I moved to 0.9.3)

Comment 8

[Sean Su]

patch checked in.  I'm not exactly sure how to go about verifying this bug 
properly, but one thing you can try is:
1) while in the download process, watch until it looks like the donwload is hung 
(not the ui).
2) when this part occurrs, time the hang part.  It should be abour 90 secs.
3) after 90secs, the process should have restarted automatically.

if this happens for more than 2 times (on the 3rd time) on the same file, then 
the installer will put issue a message that it will put the download in a Paused 
state, then put it in the Paused state (the Pause/Resume buttons should switch 
which one is enabled and disabled).

Hitting this dialog will be hard.

Comment 9

[Grace Bush]

verified this is fixed...saw it on builds around the fix date, rarely see it 
now.